Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiple assets (findRegularFontFiles) #13

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

mochiya98
Copy link
Contributor

make it possible to find all assets.

Copy link
Owner

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @mochiya98!

@patrickhulce
Copy link
Owner

Would you mind explaining the use case and/or following up with a test so we capture this better and don't break in the future?

@patrickhulce patrickhulce merged commit 5c3dcb2 into patrickhulce:master Feb 11, 2019
@mochiya98
Copy link
Contributor Author

Thanks @patrickhulce
ok. I'll add tests later.


I would be happy if you could fix nukecss package. (for debugging)
I couldn't install on latest environment.

https://github.com/patrickhulce/nukecss/blob/master/package.json#L6

  "bin": {
-    "bin/nukecss.js": "nukecss"
+    "nukecss": "bin/nukecss.js"
  },

https://github.com/patrickhulce/nukecss-webpack/blob/master/package.json#L36
https://github.com/patrickhulce/fontmin-webpack/blob/master/package.json#L50

fontmin-webpack (devDependencies)
 -> nukecss-webpack
   -> nukecss

@patrickhulce
Copy link
Owner

Oh sure, yeah I never documented/officially supported a real CLI sorry about that!

@mochiya98
Copy link
Contributor Author

mochiya98 commented Feb 12, 2019

thank you for your help.
check out that :)

patrickhulce pushed a commit that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants