fix: identify rel noopener in list (GoogleChrome#1035)

addresses GoogleChrome#1029
patrickhulce · Nov 23, 2016 · dcdabb7 · dcdabb7
1 parent 62c79b1
commit dcdabb7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -82,7 +82,7 @@ <h2>Do better web tester page</h2>
   <!-- FAIL - does not use rel="noopener" to open external link -->
   <a href="https://www.google.com/" target="_blank">external link</a>
   <!-- PASS -->
-  <a href="https://www.google.com/" target="_blank" rel="noopener">external link that uses  rel="noopener"</a>
+  <a href="https://www.google.com/" target="_blank" rel="noopener nofollow">external link that uses rel noopener and another unrelated rel attribute</a>
   <!-- PASS -->
   <a href="./doesnotexist" target="_blank">internal link is ok</a>
 </template>

diff --git a/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js b/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js
@@ -22,7 +22,7 @@ class AnchorsWithNoRelNoopener extends Gatherer {
 
   afterPass(options) {
     const driver = options.driver;
-    return driver.querySelectorAll('a[target="_blank"]:not([rel="noopener"])')
+    return driver.querySelectorAll('a[target="_blank"]:not([rel~="noopener"])')
       .then(failingNodeList => {
         const failingNodes = failingNodeList.map(node => {
           return Promise.all([