fix: identify rel noopener in list #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
suggested changes
Nov 23, 2016
| @@ -22,7 +22,7 @@ class AnchorsWithNoRelNoopener extends Gatherer { | |||
|
|
|||
| afterPass(options) { | |||
| const driver = options.driver; | |||
| return driver.querySelectorAll('a[target="_blank"]:not([rel="noopener"])') | |||
| return driver.querySelectorAll('a[target="_blank"]:not([rel*="noopener"])') | |||
There was a problem hiding this comment.
[rel~="noopener"] so we don't match craziness like rel="supercoolnoopener"
patrickhulce
force-pushed
the
noopener_fix
branch
from
7caa55c
to
a578552
Compare
ebidel
suggested changes
Nov 23, 2016
| @@ -82,7 +82,7 @@ | |||
| <!-- FAIL - does not use rel="noopener" to open external link --> | |||
| <a href="https://www.google.com/" target="_blank">external link</a> | |||
| <!-- PASS --> | |||
| <a href="https://www.google.com/" target="_blank" rel="noopener">external link that uses rel="noopener"</a> | |||
| <a href="https://www.google.com/" target="_blank" rel="noopener nofollow">external link that uses rel="noopener"</a> | |||
There was a problem hiding this comment.
maybe also update the textContent to say how this link is different
patrickhulce
force-pushed
the
noopener_fix
branch
from
a578552
to
3cef5d2
Compare
ebidel
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1029