Address nested slot issues (light DOM) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricknelson
force-pushed
the
issue-7-fix-nested-slot-issues
branch
2 times, most recently
from
b6ee160
to
f083c20
Compare
patricknelson
changed the title
1. Keep track of slots on connectedCallback() and then unwind them symmetrically on disconnectedCallback() to handle state/initialization bugs in case nested elements render from inside out 2. Ensure we restrict selection of slots only to the current element and not nested elements (i.e. from inverse perspective: traverse DOM up from slot and ensure nearest custom element is the current one being initialized).
… and unnamed slots (i.e. elements without "slot" attrib) to coexist, which is what Svelte already does. Throw error in edge case if named slots (including a named slot="default") exists with still some unnamed content/elements remaining.
…ive) debugging during package development.
…re importantly helped with debugging an issue (edge case triggered when editing in DevTools)
…n't result in selecting the wrong slots. Using direct node equality to verify that the provided slot's parent belongs to the parent currently being processed. Also documenting interesting edge case (which hopefully doesn't come up in normal use, but if it does, will have some idea of what might be happening)
… be reused later (e.g. MutationObserver's for IIFEs executed prior to parsing of the light DOM elements)
…es for easier management/reference (also quicker tests). Using "test()" function instead of "it()" due to now they're already named anyway.
…itly named default conflicts with remaining content left over. Also: Renaming top level describe()'s
…ir own slots and not conflicting with slots lower down, or, that slots lower down aren't applied to custom element tags higher up, etc.
…t/outer elements will retain their state (slots) if outer element happens to render AFTER.
patricknelson
force-pushed
the
issue-7-fix-nested-slot-issues
branch
from
a2364db
to
64bacf6
Compare
patricknelson
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for crisward/svelte-tag#7. Primary changes