This repository has been archived by the owner on May 3, 2022. It is now read-only.
Gluten, Lwt and Httpaf only repro #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a smaller test that removes all of the Dream mechanics. Again, quickly refreshing http://localhost:8080 causes the program to crash on macOS. Note that the bug does not appear when using the upstream https://github.com/inhabitedtype/httpaf but instead only appears when using Dream's fork of httpaf to use the gluten-style server.
The bug seems somewhat reminiscent of ocsigen/lwt#742 i.e. at some point the references to the various underlying buffers are going missing and so we get the segfault. It does look like the global roots code changed between OCaml 4 and 5 (ocaml/ocaml@b123728).