Discussion #722 Nested scroll and overscroll #730
Conversation
There was a problem hiding this comment.
Hello, thank you for your contribution. The over-scroll effect is a welcome addition, but it should affect just the scrollable content, not the whole composable. y-axes should not be stretched horizontally, for example. Also, both UI frameworks must have the same functionality, so the view system should also receive the over-scroll effect.
| } | ||
|
|
||
| public class VicoNestedScroll @OptIn(ExperimentalFoundationApi::class) |
There was a problem hiding this comment.
The name of this class contains "nested scroll", however, it has nothing to do with nested scrolling. The class only defines OverscrollEffect and its enabled state. Thus the name should be changed to e.g. VicoOverscrollEffect.
| public fun rememberDefaultVicoNestedScroll(applyOverscroll: Boolean = true): VicoNestedScroll { | ||
| val effect = ScrollableDefaults.overscrollEffect() |
There was a problem hiding this comment.
The effect should also be the function parameter with a default value.
| public fun rememberDefaultVicoNestedScroll(applyOverscroll: Boolean = true): VicoNestedScroll { | |
| val effect = ScrollableDefaults.overscrollEffect() | |
| public fun rememberDefaultVicoNestedScroll(effect = ScrollableDefaults.overscrollEffect(), applyOverscroll: Boolean = true): VicoNestedScroll { |
| } else { | ||
| val consumedValue = value - oldValue | ||
| pointerXDeltas.tryEmit(consumedValue - delta) | ||
| if (nestedScroll != null) consumedValue else delta |
There was a problem hiding this comment.
VicoNestedScroll being null should not determine whether nested scroll is enabled. It should be a separate boolean.
Gowsky
force-pushed
the
master
branch
2 times, most recently
from
bb88521
to
ac44341
Compare
|
Closing as per #722 (reply in thread). |
Screen_recording_20240526_173848.mp4
PR for the discussion #722