Skip to content

Commit

Permalink
fix(annotations): displaying annotation tooltips correctly (#1406)
Browse files Browse the repository at this point in the history
* chore(docs): some typos

missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)

* Revert "Merge pull request #2 from pattern-lab/dev"

This reverts commit 7812878, reversing
changes made to 26db979.

* Revert "Merge pull request #1 from pattern-lab/dev"

This reverts commit 26db979, reversing
changes made to fc90750.

* Revert "chore(docs): some typos"

This reverts commit 271dc8d.

* chore: some reformatting

* chore: formatting

* chore: formatting

This reverts commit 271dc8d.

* chore: formatting

* refactor: let's hide elements the modern way with the hidden attribute

* refactor: extracting annotations inside modal styles

* refactor: we won't need this as a generated CSS file

* Revert "Merge branch 'dev' into fix/annotations-tooltip-rendering"

This reverts commit 2c715ae, reversing
changes made to 5effb4f.

* refactor: adding some sample content for the annotations

and corrected the current approach to provide annotations JSON

* refactor: regenerated those files

Co-authored-by: Maximilian <mfr@nzke.net>
  • Loading branch information
mfranzke and Maximilian committed Jan 29, 2022
1 parent a3ec132 commit 3f33ce5
Show file tree
Hide file tree
Showing 13 changed files with 1,333 additions and 696 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
var comments = {
"comments": []
};

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
var comments = {
"comments" : [
{
"el": ".c-header",
"title" : "Masthead",
"comment": "The main header of the site doesn't take up too much screen real estate in order to keep the focus on the core content."
},
{
"el": ".c-logo",
"title": "Logo",
"comment": "The logo isn't an image but regular text, which ensures that the logo displays crisply even on high resolution displays."
}
]
};
Loading

0 comments on commit 3f33ce5

Please sign in to comment.