Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View All link missing from main Pattern Lab navigation bar #1048

Closed
coreylafferty opened this issue Sep 3, 2019 · 3 comments · Fixed by #1053
Closed

View All link missing from main Pattern Lab navigation bar #1048

coreylafferty opened this issue Sep 3, 2019 · 3 comments · Fixed by #1053
Assignees
@sghoweri

Comments

@coreylafferty
Copy link

I am using Pattern Lab Node v3.0.3 on Windows, with Node v10.15.1, using the Twig Edition.

Expected Behavior

A 'view all' link or something similar (e.g., clicking the Pattern Lab logo) takes you back to the main Pattern Lab page that lists all components.

Actual Behavior

No 'view all' link present.

image
@sghoweri sghoweri self-assigned this Sep 3, 2019
@sghoweri
Copy link
Contributor

sghoweri commented Sep 3, 2019

Assigning this to me — this should be a straightforward UIKit fix to roll out since the code re-enabling this top level All link was just commented out 🤦‍♂

@bmuenzenmeyer
Copy link
Member

adding this featue way back in PL PHP was my very first contribution to PL ❤️

sghoweri added a commit to sghoweri/patternlab-node that referenced this issue Sep 5, 2019
@sghoweri
fix: re-enable displaying the top level All link if PL isn't config…
6bb4e1a 
…ured to hide this specific link in the ishControlsHide config option. Addresses pattern-lab#1048
@sghoweri sghoweri mentioned this issue Sep 5, 2019
Merged
@thethomic
Copy link

Is it by design, that the "View All" Link inside the several folders is still showing up?
I expected this link to dissappear too when ishControlsHide.views-all: true,

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@sghoweri
fix: re-enable displaying the top level All link if PL isn't config…
36006c5 
…ured to hide this specific link in the ishControlsHide config option. Addresses pattern-lab#1048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sghoweri sghoweri

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@bmuenzenmeyer @coreylafferty @sghoweri @thethomic