Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnamespaced button style in uikit-workshop #1109

Closed
cbirdsong opened this issue Dec 4, 2019 · 5 comments · Fixed by #1227
Closed

Unnamespaced button style in uikit-workshop #1109

cbirdsong opened this issue Dec 4, 2019 · 5 comments · Fixed by #1227
Labels
released 🚀

Comments

@cbirdsong
Copy link

The button styles in this file were causing an inheritance issue in my CSS: https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/sass/scss/02-base/_reset.scss
@stale
Copy link

stale bot commented Feb 2, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@stale
Copy link

stale bot commented Apr 23, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Jun 18, 2020
fix(resetcss): selector in uikit-workshop pattern-lab#1109
6893b7c 
optimized regarding unnamespaced button style
@mfranzke mfranzke mentioned this issue Jun 18, 2020
Merged
@stale
Copy link

stale bot commented Jun 22, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@mfranzke
Copy link
Contributor

A potential fix has been provided.

sghoweri added a commit that referenced this issue Jun 28, 2020
@sghoweri
Merge pull request #1227 from mfranzke/fix-resetcss-selector-in-uikit…
e1aa86f 
…-workshop

fix(resetcss): selector in uikit-workshop #1109
@sghoweri
Copy link
Contributor

Issue was released with v5.11.1

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
fix(resetcss): selector in uikit-workshop pattern-lab#1109
eb4a6a1 
optimized regarding unnamespaced button style
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@sghoweri
Merge pull request pattern-lab#1227 from mfranzke/fix-resetcss-select…
a0e80a6 
…or-in-uikit-workshop

fix(resetcss): selector in uikit-workshop pattern-lab#1109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(resetcss): selector in uikit-workshop #1109 mfranzke/patternlab-node
3 participants
@mfranzke @sghoweri @cbirdsong