Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbars in Pattern Flyouts in Edge 18 #1124

Closed
OktarinTentakel opened this issue Feb 11, 2020 · 2 comments · Fixed by #1226
Closed

Scrollbars in Pattern Flyouts in Edge 18 #1124

OktarinTentakel opened this issue Feb 11, 2020 · 2 comments · Fixed by #1226
Labels
help wanted 🆘 pinned 📌 Don't let stalebot clean this up released 🚀 uikit

Comments

@OktarinTentakel
Copy link

Using my local setup with Patternlab Node and Uikit Workshop as well as your own example

https://patternlab-handlebars-preview.netlify.com/

I see scrollbars appearing on the corners of the top pattern flyouts. Of course this is a b-bug, since it's not breaking anything. It's just a little ugly. :D

Bildschirmfoto 2020-02-11 um 10 42 17
@bmuenzenmeyer bmuenzenmeyer added help wanted 🆘 pinned 📌 Don't let stalebot clean this up uikit labels Feb 19, 2020
@sghoweri
Copy link
Contributor

Yeah, the horizontal scrollbars especially aren't great... 🤦‍♂

PR's are most certainly welcomed to polish this up! Otherwise I'll do my best to get around to this soon (hopefully this coming weekend 🤞)

mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Jun 18, 2020
fix(patternflyouts): preventing horizontal scrollbar in pattern flyou…
63300bc 
…ts in Edge 18 pattern-lab#1124
@mfranzke mfranzke mentioned this issue Jun 18, 2020
Merged
sghoweri added a commit that referenced this issue Jun 28, 2020
@sghoweri
Merge pull request #1226 from mfranzke/fix-flyouts-removing-horizonta…
aa7e2b5 
…l-scrollbar-in-edge-18

fix(patternflyouts): preventing horizontal scrollbar in Edge 18 #1124
@sghoweri
Copy link
Contributor

Issue was released with v5.11.1

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
fix(patternflyouts): preventing horizontal scrollbar in pattern flyou…
42465fb 
…ts in Edge 18 pattern-lab#1124
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@sghoweri
Merge pull request pattern-lab#1226 from mfranzke/fix-flyouts-removin…
3b75d68 
…g-horizontal-scrollbar-in-edge-18

fix(patternflyouts): preventing horizontal scrollbar in Edge 18 pattern-lab#1124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted 🆘 pinned 📌 Don't let stalebot clean this up released 🚀 uikit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(patternflyouts): preventing horizontal scrollbar in Edge 18 #1124 mfranzke/patternlab-node
3 participants
@bmuenzenmeyer @sghoweri @OktarinTentakel