Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Node 8 #870

Closed
4 tasks
bmuenzenmeyer opened this issue Jun 29, 2018 · 11 comments
Closed
4 tasks

Move to Node 8 #870

bmuenzenmeyer opened this issue Jun 29, 2018 · 11 comments

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Jun 29, 2018

Dropping 6 in favor of 8 will move with the Node LTS "Active" schedule, the industry as a whole, and allow us to use newer language features like async / await

  • nvmrcs
  • travis environments
  • package.json engines
  • documentation / README / shields
@EvanLovely
Copy link
Member

Love this. Gotta say: async / await is super handy & much more readable than other approaches.

@stale
Copy link

stale bot commented Sep 13, 2018

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@benhalverson
Copy link
Contributor

Hey @bmuenzenmeyer Do you mind if I work on this?

benhalverson added a commit to benhalverson/patternlab-node that referenced this issue Sep 24, 2018
benhalverson added a commit to benhalverson/patternlab-node that referenced this issue Sep 25, 2018
Starting Oct 2018 v10.x will become an active LTS

pattern-lab#870
benhalverson added a commit to benhalverson/patternlab-node that referenced this issue Sep 25, 2018
@stale
Copy link

stale bot commented Nov 23, 2018

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@stale
Copy link

stale bot commented Dec 7, 2018

Issue closed after going stale. It can be re-opened if still relevant.

@stale stale bot closed this as completed Dec 7, 2018
@sghoweri sghoweri reopened this Dec 7, 2018
@sghoweri
Copy link
Contributor

sghoweri commented Dec 7, 2018

Reopening — my gut tells me that this should be pretty straight forward to bang out the minimum updates needed for this (aka we could upgrade to Node 8 but hold off refactoring any logic to use async/await till a later batch of updates).

@bradfrost
Copy link
Member

@sghoweri That sounds good. I wouldn't trust me to do that upgrade, but in any case I'd hope the universe doesn't blow up by upgrading.

@benhalverson
Copy link
Contributor

benhalverson commented Dec 7, 2018

@sghoweri @bradfrost This is already done see #951 and #951 (comment) about going to node 10 instead of 8

@bradfrost
Copy link
Member

@benhalverson ah thanks for the heads up. @sghoweri does this sort you out?

@stale
Copy link

stale bot commented Feb 14, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@sghoweri
Copy link
Contributor

Closing this out. Going with Node >=10 sounds great to me (lots of optimizations we’ll be able to get in) and the updates bumping the min version needed (#951) shipped with the latest beta we cut last week!

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
Starting Oct 2018 v10.x will become an active LTS

pattern-lab#870
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants