Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let any package be installed as a Patternlab starterkit. #1067

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Let any package be installed as a Patternlab starterkit. #1067

merged 2 commits into from
Oct 11, 2019

Conversation

ringods
Copy link
Contributor

@ringods ringods commented Oct 5, 2019

Closes #1065

Summary of changes:

  • Drop the check that the package name of the starterkit begins with @pattern-lab/ namespace.

@ringods
Copy link
Contributor Author

ringods commented Oct 5, 2019 •
edited
Loading

When accepted, can this be included in a release of @pattern-lab/cli as swiftly as possible? Otherwise I still can't benefit from my own contribution. 😉

bmuenzenmeyer
bmuenzenmeyer approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a straightforward change - thanks!

@bmuenzenmeyer bmuenzenmeyer merged commit d2aa1be into pattern-lab:dev Oct 11, 2019
@bmuenzenmeyer
Copy link
Member

planning on releasing this and other PRs today

@ringods
Copy link
Contributor Author

ringods commented Oct 13, 2019

Thank you very much @bmuenzenmeyer! 🤗

@ringods ringods deleted the fix/install-any-starterkit branch October 13, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@raphaelokon raphaelokon Awaiting requested review from raphaelokon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing own starterkit fails
2 participants
@ringods @bmuenzenmeyer