Fix/plugin and clean fixes #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of #1074 was merged out
sghoweri
reviewed
Nov 12, 2019
|
|
|
Odd I see this.
|
|
Seeing a JS error in Safari (iOS and for Mac) — seeing if I can troubleshoot!
|
sghoweri
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
@bmuenzenmeyer with the small fix I just pushed up (JS fix for Safari), this is looking good to go on my end!
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…lean-fixes Fix/plugin and clean fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some problems on
devprior to publishSummary of changes:
@sghoweri if you could review, please do!