Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: a11y issues on overview pages #1113

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Fix: a11y issues on overview pages #1113

merged 2 commits into from
Dec 31, 2019

Conversation

mfranzke
Copy link
Contributor

Summary of changes: fixing some a11y issues on the overview pages.

  • The text colors used for some textual parts weren't at least following the 4.5 convention for AA compatibility on the white page background.
  • Missing description of that complementary icon fixed by hiding this element via aria-hidden

@mfranzke
fix: a11y issue on a missing description of that complementary icon
4f13807 
Firefox a11y analysis on developer tools is mentioning the missing description on that complementary icon, so we could easily remove it from the accessibility tree
@mfranzke
fix: a11y fix on text contrast
6d75b22 
both introduced a new shade of the gray color - next fit to the 50, that is even already higher than 4.5, which is the minimum for AA a11y definition
@mfranzke mfranzke changed the title Fix/a11y issues on overview pages Fix: a11y issues on overview pages Dec 23, 2019
@sghoweri
Copy link
Contributor

Thanks @mfranzke!!

@bmuenzenmeyer bmuenzenmeyer merged commit ec50b62 into pattern-lab:dev Dec 31, 2019
@bmuenzenmeyer
Copy link
Member

thanks @mfranzke !

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@bmuenzenmeyer
Merge pull request pattern-lab#1113 from mfranzke/fix/a11y-issues-on-…
aceefbe 
…overview-pages

Fix: a11y issues on overview pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@sghoweri sghoweri Awaiting requested review from sghoweri sghoweri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfranzke @sghoweri @bmuenzenmeyer