fix: update twig-renderer #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanLovely
added
bug 🐛
twig renderer
sghoweri
approved these changes
Feb 24, 2020
EvanLovely
added a commit
to eGovPDX/portlandor
that referenced
this pull request
Feb 24, 2020
Fixed by upgrading dependency on `@pattern-lab/engine-twig-php`: pattern-lab/patternlab-node#1129 Which in turn updates dependency on `@basalt/twig-renderer`: https://github.com/basaltinc/twig-renderer/releases/tag/v0.13.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
engine-twig-php's dependency on@basalt/twig-rendererfrom v0.13.0 to v0.13.1. This fix resolves an issue when using Pattern Lab in a Docker container where it doesn't have permissions to write to certain directories. That functionality wasn't critical (only used for keeping track of ports handed out) and could be kept in-memory - which is what this update does. Also it removes a dependency! Would appreciate a speedy merge & release on this as it's causing some errors for one of our clients using Pattern Lab 😁 🙏