-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initial Github Actions setup #1187
Conversation
While introducing Github actions, I looked in one
Would it be OK to set the |
I am fine with that yes. My guiding light is the top-level it looks like the README still says 6 too, 🤣 |
8bc411a
to
abd93c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sghoweri is the CONTRIBUTING GUIDE in the uikit still relevant?
@bmuenzenmeyer Unfortunately not. I'm good with nuking it and starting from scratch |
@ringods I'm 100% good with requiring a minimum of Node v12 or higher. Big thumbs up from me on that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm good with moving forward with all of this.
RE Github Actions, I'm totally open to trying it out here (I've tried it out a few times actually) however I wouldn't recommend nixing Travis until we're certain we're actually getting something out of switching (vs same build times and no major improvements otherwise).
Definitely worth giving it a try! 👍
this run (sample size of 1): GH Actions were 25 seconds faster - though I'd have to look closer at whether or not coveralls is contributing to time in Travis. |
I suggest to leave Github Actions and Travis running side by side for a while. @bmuenzenmeyer not only look at the runtime (run start -> run end), but at the total lead time (git push -> run end). My experience is that Travis could take a while before the run sometimes starts. This is not reported as part of the runtime in the respective web portals. As an example, for the last run (your sample size of 1), I compared the Github actions start time to the Travis start time:
So on this sample size, Travis was not only 25 seconds slower, it also started 11 seconds later. On other projects, I experienced this start delay to add up to 1.5 minutes. Nevertheless, let's get this PR merged! 😉 |
…ctions Adding initial Github Actions setup
Closes #1185
Summary of changes:
test
script via Yarn.For reference of viewers later on: