Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial Github Actions setup #1187

Merged
merged 4 commits into from
May 7, 2020
Merged

Conversation

ringods
Copy link
Contributor

@ringods ringods commented May 1, 2020

Closes #1185

Summary of changes:

  • Added the basic setup to run the test script via Yarn.

For reference of viewers later on:

@ringods ringods marked this pull request as draft May 1, 2020 13:18
@ringods
Copy link
Contributor Author

ringods commented May 1, 2020

@sghoweri @bmuenzenmeyer

While introducing Github actions, I looked in one package.json file for the engines setting. I found ">=10.0" in that file. I configured the Github Actions runner to use NodeJS 10.x, but the build fails because the following 2 packages requiring NodeJS 12:

  • engine-handlebars
  • development-edition-engine-handlebars.

Would it be OK to set the engines section to ">=12.0" in every package.json file of the monorepo, document this minimum version in the installation section and update my Github Actions config to use NodeJS 12?

@bmuenzenmeyer
Copy link
Member

Would it be OK to set the engines section to ">=12.0" in every package.json file of the monorepo, document this minimum version in the installation section and update my Github Actions config to use NodeJS 12?

I am fine with that yes. My guiding light is the top-level .nvmrc file. https://github.com/pattern-lab/patternlab-node/blob/dev/.nvmrc

it looks like the README still says 6 too, 🤣

@ringods ringods self-assigned this May 1, 2020
@coveralls
Copy link

coveralls commented May 1, 2020

Coverage Status

Coverage remained the same at 73.388% when pulling db86acb on feature/github-actions into 54f1bb4 on dev.

@ringods ringods marked this pull request as ready for review May 1, 2020 17:32
@ringods ringods requested a review from bmuenzenmeyer May 1, 2020 17:33
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sghoweri is the CONTRIBUTING GUIDE in the uikit still relevant?

@sghoweri
Copy link
Contributor

sghoweri commented May 5, 2020

@sghoweri is the CONTRIBUTING GUIDE in the uikit still relevant?

@bmuenzenmeyer Unfortunately not. I'm good with nuking it and starting from scratch

@sghoweri
Copy link
Contributor

sghoweri commented May 5, 2020

Would it be OK to set the engines section to ">=12.0" in every package.json file of the monorepo, document this minimum version in the installation section and update my Github Actions config to use NodeJS 12?

@ringods I'm 100% good with requiring a minimum of Node v12 or higher. Big thumbs up from me on that!

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm good with moving forward with all of this.

RE Github Actions, I'm totally open to trying it out here (I've tried it out a few times actually) however I wouldn't recommend nixing Travis until we're certain we're actually getting something out of switching (vs same build times and no major improvements otherwise).

Definitely worth giving it a try! 👍

@bmuenzenmeyer
Copy link
Member

this run (sample size of 1): GH Actions were 25 seconds faster - though I'd have to look closer at whether or not coveralls is contributing to time in Travis.

@ringods
Copy link
Contributor Author

ringods commented May 6, 2020

I suggest to leave Github Actions and Travis running side by side for a while.

@bmuenzenmeyer not only look at the runtime (run start -> run end), but at the total lead time (git push -> run end). My experience is that Travis could take a while before the run sometimes starts. This is not reported as part of the runtime in the respective web portals.

As an example, for the last run (your sample size of 1), I compared the Github actions start time to the Travis start time:

  • Github Actions: in the black console part, click on the 3 dots in the upper right and select Show timestamps, then expand the first block Setup job. I record the first date listed: Tue, 05 May 2020 14:08:52 GMT
  • Travis CI raw output: line 9 shows the first time in epoch style: start=1588687743792683790. Converting this to regular datetime gives: Tuesday, 5 May 2020 14:09:03.792 GMT

So on this sample size, Travis was not only 25 seconds slower, it also started 11 seconds later. On other projects, I experienced this start delay to add up to 1.5 minutes.

Nevertheless, let's get this PR merged! 😉

@bmuenzenmeyer bmuenzenmeyer merged commit 425954d into dev May 7, 2020
@bmuenzenmeyer bmuenzenmeyer deleted the feature/github-actions branch May 7, 2020 11:32
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…ctions

Adding initial Github Actions setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions over Travis-CI?
4 participants