Fix default behavior of nested patterns #1232
Conversation
JosefBredereck
changed the title
| test.equals(p1.name, '00-atoms-00-global-00-colors-variant'); | ||
| test.equals(p2.name, '00-atoms-00-global-00-colors-variant-minus'); | ||
| test.equals(p1.name, '00-atoms-00-global-colors-variant'); | ||
| test.equals(p2.name, '00-atoms-00-global-colors-variant-minus'); |
There was a problem hiding this comment.
So glad to see this going away -- this has always been one of those annoying things with how the filename / URL structure was assembled 👍
| (patternlab && | ||
| patternlab.config && | ||
| patternlab.config.allPatternsAreDeeplyNested) |
There was a problem hiding this comment.
@JosefBredereck I can't wait for when we can switch to using Node 14+ which now supports optional chaining natively, no Babel transpiling required!
There was a problem hiding this comment.
Yes, I was using patternlab?.config?.allPatternsAreDeeplyNested first, but then it did not work. (Had still V13.x)
But we need to be careful since not everyone uses V14+ now and maybe not for a long time.
| @@ -59,3 +59,5 @@ The `deeplyNested` attribute is used to toggle the pattern building behavior and | |||
|
|
|||
| - **deeplyNested not set or false** - Pattern won't be handled as a deeply nested pattern | |||
| - **deeplyNested: true** - Pattern will be handled like mentioned under [Deeper Nesting](#heading-deeper-nesting) | |||
|
|
|||
| To turn on this behavior globally, just add `"allPatternsAreDeeplyNested": true` to your `patternlab-config.json`. | |||
There was a problem hiding this comment.
+1 so existing PL installs not already switched to using allPatternsAreDeeplyNested won't run into any file name / path changes; just applies to the new spec we're moving towards.
There was a problem hiding this comment.
I'm good with this -- all small sensible changes + only scoped to the latest (new) opt-in allPatternsAreDeeplyNested config option. 👍
Thanks @JosefBredereck!
JosefBredereck
added
ready for release 🆗
released 🚀
and removed
ready for release 🆗
labels
Summary of changes:
Switched the default pattern creation way. For missing
.mdfiles there was an issue with nested pattern folders and also variants were not working as expected.