Fix too much recursion and update node-sass #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JosefBredereck LGTM |
sghoweri
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Ah, yep. I'm super familiar with this self to this web component constructor updates -- all sensible changes and everything still seems to work fine when spot checking these particular components getting the updates.
Thanks @JosefBredereck!
JosefBredereck
added
ready for release 🆗
released 🚀
and removed
ready for review
ready for release 🆗
labels
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…ursion Fix too much recursion and update node-sass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
When the UI-kit has been rendered there was a reappearing "too much recursion" error. That should be resolved with this PR.