Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_plugin and is_plugin is not used anymore in the code base #1240

Merged
merged 1 commit into from
Aug 23, 2020
Merged

load_plugin and is_plugin is not used anymore in the code base #1240

merged 1 commit into from
Aug 23, 2020

Conversation

ringods
Copy link
Contributor

@ringods ringods commented Aug 19, 2020

Summary of changes:

  • load_plugin and is_plugin on plugin_manager is not used anymore in the codebase. Cleaning up.

@ringods ringods self-assigned this Aug 19, 2020
JosefBredereck
JosefBredereck approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@JosefBredereck JosefBredereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the good old plugin code to load by name ^plugin- will now be gone for all time 👍

@ringods ringods merged commit 8377d99 into dev Aug 23, 2020
@ringods ringods deleted the feature/cleanup-is-plugin branch August 23, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefBredereck JosefBredereck JosefBredereck approved these changes

Assignees

@ringods ringods

Labels
released 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ringods @JosefBredereck