refactor: replace node-sass by sass #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mporter node-sass is deprecated, integrated its successor sass instead; and node-sass-selector-importer never seems to have been used
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
to even also prevent the usage of math.div
…lector-importer" This reverts commit ca72dcf.
…mpo… …rter node-sass is deprecated, integrated its successor sass instead; and node-sass-selector-importer never seems to have been used
78 tasks
JosefBredereck
approved these changes
Nov 21, 2021
Merged
38 tasks
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor: replaced node-sass by sass and removed node-sass-selector-importer node-sass is deprecated, integrated its successor sass instead; and node-sass-selector-importer never seems to have been used * refactor(scss): replaced by new Dart Sass syntax DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0. * refactor: simplified those calculations to even also prevent the usage of math.div * Revert "refactor: replaced node-sass by sass and removed node-sass-selector-importer" This reverts commit ca72dcf. * refactor: replaced node-sass by sass and removed node-sass-selector-impo… …rter node-sass is deprecated, integrated its successor sass instead; and node-sass-selector-importer never seems to have been used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
As
node-sassis deprecated, we're replacing it with its successor Dart Sass, which even also has a npm package.Additionally removing package
node-sass-selector-importer, which got introduced with commit 3d38d43, but never seems to have been used within the SCSS source code.And we needed to switch to the new Dart Sass syntax for divisions within some of the
scssfiles; this process got simplified by the usage ofsass-migrator/npx sass-migrator division **/**.scss:This would as well prevent some node-gyp warnings that might pop up in edge cases, as Dart Sass is a direct JavaScript implementation of SASS.
I've checked the output of the operation within the file https://github.com/pattern-lab/patternlab-node/pull/1373/files#diff-16d6427ba133722f108966c95c3eae01b3942556dd26ad24271950e0c9f5bd63R26 line by line both for using
node-sassandsassand it's equal (content-wise, except for different formatting):