Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue #156
I think this is fairly well commented, but here's a general overview:
diveSync iterates through all pattern files once to populate the patternlab.patterns array. This is necessary because a recursive inclusion of partials requires that all partial patterns exist in that array. Prior to this pr, any attempt to include partials occurring later in alphanumeric order would fail and break patternlab, because the patternlab.patterns data that the include operation was looking for was non-existent.
Therefore, another diveSync operation is required to do the actual recursion. This second diveSync successfully populates the extendedTemplate properties because the template properties were previously populated for all partials in the previous diveSync operation.
Please review, comment, and merge.