New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twig PHP Engine in Pattern Lab node #897
Merged
Merged
Changes from 9 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
fde7f8a
Copying engine-twig to engine-twig-php
EvanLovely f17b631
Name change: engine-twig => engine-twig-php
EvanLovely 89d88e8
Creating the Twig PHP Engine for Pattern Lab Node
EvanLovely 6095ee6
Setting up the Twig Edition using the PHP engine
EvanLovely 5a081ac
Merge branch 'master' into feature/engine-twig-php
EvanLovely 4fb5469
Ensuring Travis is using latest npm
EvanLovely 33ee339
Removing package-lock.json
EvanLovely 7086b89
Preventing lerna from using npm ci
EvanLovely 33d25e1
fix(package): remove package-lock.json
bmuenzenmeyer 19b4268
fix(edition): ignore dependencyGraph.json
bmuenzenmeyer 004fd59
Improving error handling
EvanLovely c7f0396
Merge branch 'feature/engine-twig-php' of github.com:pattern-lab/patt…
EvanLovely a3dc7c0
Removing travis npm upgrade and no-ci flag to lerna bootrap
EvanLovely 7b1433c
pinning exact deps
EvanLovely fb5307e
Enabling recursive Twig namespaces
EvanLovely 7c2e376
Adding Alter Twig example
EvanLovely 09d135a
Removing source folder of edition-twig as that can get pulled in via …
EvanLovely 207eb5b
refactor: port over Twig partials from Styleguidekit Twig Default's r…
bolt-bot 52d0d97
refactor: add @pattern-lab/starterkit-twig-demo as a dependency to te…
bolt-bot 5426bc4
refactor: refactor PL node to support the ability to have uikit view …
bolt-bot 3d0a0ac
chore: remove unused config option
bolt-bot 0c965cc
fix: clean up Pattern.createEmpty conditionals to improve readability…
bolt-bot 9edae65
Merge branch 'dev' into feature/engine-twig-php--uikit-twig
bolt-bot d510550
Revert "Merge branch 'dev' into feature/engine-twig-php--uikit-twig"
bolt-bot 52a274b
chore: add example of the Twig debug extension to alter-twig.php to s…
bolt-bot 19fd272
chore: remove Twig starterkit dependency per PR feedback
sghoweri 018a910
chore: revert Twig starterkit-specific path changes
sghoweri 18ac7a5
chore: revert remaining Twig starterkit path changes in PL config
sghoweri fbf9476
disabling example of Twig_Extension_Debug
EvanLovely 5b0c56c
Merge pull request #907 from sghoweri/feature/add-twig-debug-ext-example
EvanLovely 948cafc
updating twig-renderer
EvanLovely b475374
increasing minimum node version 6 => 8
EvanLovely 36a63f7
Merge pull request #902 from sghoweri/feature/engine-twig-php--uikit-…
sghoweri 596780c
Merge branch 'dev' into feature/engine-twig-php
EvanLovely 5643bbe
fixing edition-twig to render; it works!
EvanLovely 1bf572b
refactor: migrate twig starterkit demo into PL Node monorepo
sghoweri 2c90d0e
chore: fix prettier issues
sghoweri f3b3b84
refactor: add twig edition starter folders
sghoweri 93e84c0
Merge branch 'feature/engine-twig-php' of https://github.com/pattern-…
sghoweri 6fc5590
chore: add images folder to twig edition folders
sghoweri e603840
style: prettier lint fix
EvanLovely edb4300
Merge branch 'feature/engine-twig-php' of github.com:pattern-lab/patt…
EvanLovely 1ec58f4
chore: ignore annotation files from prettier
sghoweri 320c2cc
Merge branch 'feature/engine-twig-php' of https://github.com/pattern-…
sghoweri 42bfe29
fix: revert previous uikit configurable path updates to unblock Twig …
sghoweri 962020b
fix: revert fixing prettier issues with annotations.js file to fix fa…
sghoweri d8747bf
chore: update uikit build assets
sghoweri a408bbc
fix: temporarily revert using twig-based UI for certain bits of rende…
sghoweri File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| language: node_js | ||
|
|
||
| before_install: | ||
| - npm i -g npm | ||
| - phantomjs --version | ||
|
|
||
| before_script: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like doing this - as npm has been known to break itself even with minor or patch releases. Since the .travis.yml file should be supplying Node versions, it also reliably gets the npm version bundled with Node
I think this was added as a troubleshooting step. If so, please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, another PL Node newb question here: any particular reason why aren’t we using Yarn + Lerna Workspaces here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We focused on Lerna for our initial monorepo conversion. I don't want to get into the game of documenting everything with npm and yarn. npm 5+ has come a long way., blunting the original benefits of yarn to me. We do not use lockfiles (as you can see the problems in this PR) anyways, further blunting the need. I understand we could use yarn for dev and posture to users only npm, but I don't really understand the need for yet another tool. Please let me know if I am missing something here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less tools is better IMO :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was done as a troubleshooting step; removed now.