-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workaround for the Pattern Lab UIKit viewport resizer in Safari or Firefox #903
fix: workaround for the Pattern Lab UIKit viewport resizer in Safari or Firefox #903
Conversation
…ogo-sizing fix: adjust logo sizing in readme
…lly getting stuck with a width of 0px in Safari and Firefox when the JS is initially booting up
…oweri/patternlab-node into fix/fix-uikit-viewport-width
@bmuenzenmeyer is there some husky commit hook that's auto-formatting the Sass in PL Node? I try to be super careful when putting in bug fixes (ie. only change https://github.com/pattern-lab/patternlab-node/pull/903/files#diff-85e5b7f444b355978526b5741a653b52R50 vs that + reformat the whole Sass file) however twice now I've seen that file re-format and save while doing my commit / push... just want to make sure I'm not going crazy here 😅 |
Yes prettier is run via precommit. It should honor the |
@sghoweri I expect PRs to target the dev branch but have noticed contributors tripping up on this. @pattern-lab/javascript what are your thoughts on switching the default branch to |
…rt-width fix: workaround for the Pattern Lab UIKit viewport resizer in Safari or Firefox
Workaround fix to address the viewport resizer occasionally getting stuck with a width of
0px
in Safari and Firefox when the JS is initially booting up, causing the viewport page to appear to be completely hidden until the window is resized, etc.Addresses the same UI issue reported here: #897 (comment)