Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for the Pattern Lab UIKit viewport resizer in Safari or Firefox #903

Merged
merged 8 commits into from
Jul 24, 2018

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Jul 22, 2018

Workaround fix to address the viewport resizer occasionally getting stuck with a width of 0px in Safari and Firefox when the JS is initially booting up, causing the viewport page to appear to be completely hidden until the window is resized, etc.

Addresses the same UI issue reported here: #897 (comment)

bmuenzenmeyer and others added 8 commits July 9, 2018 09:31
 - @pattern-lab/cli@0.0.1-alpha.23
 - @pattern-lab/edition-node@1.0.0-alpha.13
 - @pattern-lab/edition-node-gulp@2.0.0-alpha.15
…ogo-sizing

fix: adjust logo sizing in readme
…lly getting stuck with a width of 0px in Safari and Firefox when the JS is initially booting up
@sghoweri
Copy link
Contributor Author

@bmuenzenmeyer is there some husky commit hook that's auto-formatting the Sass in PL Node?

I try to be super careful when putting in bug fixes (ie. only change https://github.com/pattern-lab/patternlab-node/pull/903/files#diff-85e5b7f444b355978526b5741a653b52R50 vs that + reformat the whole Sass file) however twice now I've seen that file re-format and save while doing my commit / push... just want to make sure I'm not going crazy here 😅

sghoweri pushed a commit to sghoweri/patternlab-node that referenced this pull request Jul 23, 2018
@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer is there some husky commit hook that's auto-formatting the Sass in PL Node?

Yes prettier is run via precommit. It should honor the .prettierignore file, so we can test that out.

@bmuenzenmeyer
Copy link
Member

@sghoweri I expect PRs to target the dev branch but have noticed contributors tripping up on this.

@pattern-lab/javascript what are your thoughts on switching the default branch to dev so this happens automatically? Is there a perceived downside when your visit a project and notice that master is not the default?

@bmuenzenmeyer bmuenzenmeyer changed the base branch from master to dev July 24, 2018 15:53
@bmuenzenmeyer bmuenzenmeyer merged commit 1f14270 into pattern-lab:dev Jul 24, 2018
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…rt-width

fix: workaround for the Pattern Lab UIKit viewport resizer in Safari or Firefox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants