Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release: v3.0.0-beta.2 #985

Merged
merged 115 commits into from
Feb 9, 2019
Merged

Next Release: v3.0.0-beta.2 #985

merged 115 commits into from
Feb 9, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Feb 2, 2019

Summary of changes:

Updates & Improvements

Fixes

sghoweri and others added 30 commits September 9, 2018 08:21
…nal classnames when rendering, and feature check for Shadow DOM support
… display inline isn't centered as expected for example.
…ithin JavaScript components + add support for JS components loading Sass files that aren't intended to be inlined; add support for externally exposing build config options via cosmic config
… toggling the theme and layout config options
…es by the <pl-toggle-theme> and <pl-toggle-layout> components
…dling the flex box direction changes for the modal / viewport components
…e of the page; update to account for vertical vs horizontal layouts
bolt-bot and others added 18 commits October 27, 2018 11:51
…ch-component

UIKit Refactor Part 6: Refactor Search / Typeahead Component, Bug Fixes, and Improved Scrolling
find all patterns including pseudo patterns and sort them after
retrieving all patterns instead of inject them in the array working on

fixes issue #975
fix(edition links) Broken package links within the monorepo. Fixes #954
fix(patterns): find all patterns inlcuding pseudo patterns
@sghoweri sghoweri added this to the 3.0.0 milestone Feb 2, 2019
@coveralls
Copy link

coveralls commented Feb 2, 2019

Coverage Status

Coverage decreased (-0.5%) to 74.081% when pulling e387eca on dev into 02764b2 on master.

@sghoweri
Copy link
Contributor Author

sghoweri commented Feb 2, 2019

@bradfrost three big items we need to decide on before potentially cutting the next beta release:

  1. Do we want to try and get this potential fix for the long-running View All issue merged down to dev
  2. What about the next 2 rounds of UIKit updates (also still waiting to get merged down):
  3. Cutting a new release (ie. merging down to master before publishing something) requires someone to review and OK this. Who?

@bmuenzenmeyer
Copy link
Member

👋

Thanks for stepping up @sghoweri - it's clear your passion and energy will help us all!

As for #977 I was reluctant to merge that once you stated you observed deeper issues, and I had a slow-cooking fix myself, but nothing concrete yet.

As for releasing, I can help teach you. Can we have a chat on Friday?

@sghoweri
Copy link
Contributor Author

sghoweri commented Feb 6, 2019

👋

Thanks for stepping up @sghoweri - it's clear your passion and energy will help us all!

As for #977 I was reluctant to merge that once you stated you observed deeper issues, and I had a slow-cooking fix myself, but nothing concrete yet.

As for releasing, I can help teach you. Can we have a chat on Friday?

Thanks @bmuenzenmeyer - that sounds great! Just let me know what time you want to chat on Friday!!

@bmuenzenmeyer bmuenzenmeyer self-requested a review February 8, 2019 16:39
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @sghoweri

I can not currently devote the time to review this thoroughly - but trust you and the community.

@sghoweri
Copy link
Contributor Author

sghoweri commented Feb 9, 2019

Merging this down to master — cutting the next beta shortly!

@sghoweri sghoweri merged commit 22b5d73 into master Feb 9, 2019
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants