-
Notifications
You must be signed in to change notification settings - Fork 459
Add a Method to Export Pages and Static Assets #67
Comments
So is the idea here to have a version of |
My idea was that an export would end up with something like:
Seems sort of thin but that's what I got from #40. Low on the list. |
OK, yeah. I mean that all sounds great, but I agree it should be low on the Brad Frost On Fri, Dec 6, 2013 at 2:54 PM, Dave Olsen notifications@github.com wrote:
|
I’d like to resurface this one with higher priority for one reason: unit testing in older devices (e.g. BB4 is a PiTA because the extra JS makes the page so big (and causes hanging). To accomplish this, you would need to be able to set up your own header and footer bits ( Thoughts? |
It shouldn't be difficult. Do you want all of the pattern exported this way or just pages? Or some combo? I'm currently working through the Windows bug but then I can move onto the stuff I've tagged as |
I think having every pattern would be awesome. On Tue, Feb 4, 2014 at 2:38 PM, Dave Olsen notifications@github.com wrote:
|
Ok, so the requirements (for your needs at least) are "every pattern exported with a single custom header/footer combo (v0.7.0 introduced two patterns for that FWIW) and sans any PL BS". Correct? |
Yes, please! On Tuesday, February 4, 2014 at 2:59 PM, Dave Olsen wrote:
|
Circling back to this after a little more thought… what would you think about tuning the PL JS to dynamically load in the JS and CSS resources needed within the software? I think the base HTML could stay in the generated files, but things like this:
Might be better injected into the iFrame by the wrapper. Thoughts? |
One of the requirements of PL is that it needs to limit dependencies. This includes Apache. I can't inject to the iFrame when files are served with the |
Oh well, it was worth a thought. On Thu, Feb 6, 2014 at 11:21 AM, Dave Olsen notifications@github.comwrote:
|
Based on your missive today does this mean that you're happy to use the "raw" version of patterns as they're built now as long as I drop the loading of select JS/CSS? Unfortunately, |
For now I've made sure that the Pattern Lab-specific JavaScript in each pattern is only loaded when it's in a frame. That should work for now. This feature is in I won't close this issue. I'd still like to add a true "export" feature. |
Sorry for the radio silence… I was prepping for a trip. Thanks so much for this @dmolsen! Any ETA for the release? When I return this Sunday, I may have some time to help. Let me know if you want me to jump in on anything. |
Doh, I wrote too soon. It looks like 0.7.2 is ready. I’ll give it a whirl. Anything I ned to know migration-wise? I’m running v0.6.0 still. |
You didn't write too soon. This set of features is going to roll-out in Kept you in mind for the upgrade ;) The big thing for you is to back-up your version of |
Thanks! On Mon, Feb 10, 2014 at 10:43 AM, Dave Olsen notifications@github.comwrote:
|
Just adding this in here for my own sanity. Are we talking about conditionally removing this bit from
and this from
Yeah? So the idea is to have a clean build devoid of any reference to Pattern Lab. We're doing some IE testing now where I'm having to manually go in and these out in order to get the page not to hang. Definitely something worth taking on. |
Longer-term? Yes. In the short-term I've implemented a feature in |
In talking to @bradfrost we will pursue the following as a first step:
A "converter" is a separate process/feature. |
This issue builds off of ideas raised in #40. Create an
export/
folder in the root of Pattern Lab into which static assets and Pages can be copied to fromsource/
.The text was updated successfully, but these errors were encountered: