If both ish config settings are used, use the larger value #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2017
bmuenzenmeyer
approved these changes
Oct 31, 2017
|
Latest release at https://www.npmjs.com/package/styleguidekit-assets-default will port into 4.X branches too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a
release/3.xbranch and branched it off the last 3.x tagged release, v3.5.0. This PR is pointing to that branch and should become v3.5.1.If both
config.ishViewportRangeandconfig.ishMaximumare used, thenconfig.ishViewportRangetakes precedence. This PR makes it so that if both are present, the larger one is used. I could see this being helpful if you are trying to limit the upper end of the large view to something in the area of 1200-1600px wide, but you want to be able to expand it 2000px wide when you click "Full". The current setup doesn't even allow the resize bar to move past the large size.Relates to pattern-lab/patternlab-php-core#131