-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] List style spacing, pfe-styles #878
Comments
List stylesDefaultSpecsLight theme
Dark theme
Spacing
RulesSpecsLight theme
Dark theme
SpacingUnorderedSpecsLight theme
Dark theme
Spacing
OrderedSpecsLight theme
Dark theme
Spacing
Unordered with NestedSpecsLight theme
Dark theme
Spacing
Ordered with NestedSpecsLight theme
Dark theme
Spacing
Spacing legend |
@coreyvickery These specs are gorgeous! @starryeyez024 Do we want to tackle these as styles in pfe-base or do we want to build a presentational component? |
These list styles are already a part of pfe-styles, in the pfe-base.css: Unfortunately the way HTML works, you have one place to define padding which includes the space that the number lives in. This is good in the sense that it allows for right alignment of the numbers themselves. I used these files for reference, but perhaps they could be modified to reflect how HTML works, @coreyvickery ? |
@starryeyez024 Do you think we can close this issue then if the styles already exist in pfe-styles or is there an implementation we're missing? |
@starryeyez024 Updated documentation with new images. |
@coreyvickery can you share the link to what you're referring to, and feel free to weigh in on Cassondra's question if you think we need to nudge any spacing. Otherwise I'd call this good. |
@starryeyez024 Sorry, here is the artboard in XD. The mauve spacer is 48px. |
@castastrophe Do you know if what exists in |
@coreyvickery I'm not sure. I'll make a note to do an audit. |
@starryeyez024 @castastrophe The styles in the link above look good. |
No description provided.
The text was updated successfully, but these errors were encountered: