Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] List style spacing, pfe-styles #878

Open
coreyvickery opened this issue May 15, 2020 · 11 comments
Open

[update] List style spacing, pfe-styles #878

coreyvickery opened this issue May 15, 2020 · 11 comments
Labels
design specs complete design system Updates or issues to align components to the Red Hat Design System. fix update component request

Comments

@coreyvickery
Copy link
Collaborator

No description provided.

@coreyvickery
Copy link
Collaborator Author

coreyvickery commented May 18, 2020

List styles

Default

List style - Default

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

All Lists have 9px or 0.5rem of space between text or links. If text or links occupy only a single line, the line height is 2.0.

List style - Default - Spacing


Rules

List style - Horizontal rules

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

List style - Horizontal rules - Spacing


Unordered

List style - Unordered

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

48px spacer from the edge of the container to the edge of the text.

Unordered


Ordered

List style - Ordered

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

48px spacer from the edge of the container to the edge of the text.

Ordered


Unordered with Nested

List style - Unordered - Nested

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

48px spacer from edge to edge.

Unordered nested


Ordered with Nested

List style - Ordered - Nested

Specs

Light theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-black-900 (#151515)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-400 (#06c)

Dark theme

  • Text: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-white (#fff)
  • Link: Red Hat Text, Regular, 18pt / 27 (1.5), $pf-color-blue-300 (#2b9af3)

Spacing

48px spacer from edge to edge.

Ordered nested

Spacing legend
https://www.patternfly.org/v4/design-guidelines/styles/spacers

@coreyvickery coreyvickery added design system Updates or issues to align components to the Red Hat Design System. feature New feature or request labels May 18, 2020
@starryeyez024 starryeyez024 removed their assignment May 28, 2020
@castastrophe castastrophe changed the title List styles [NEW] List styles Apr 27, 2021
@castastrophe
Copy link
Contributor

@coreyvickery These specs are gorgeous! @starryeyez024 Do we want to tackle these as styles in pfe-base or do we want to build a presentational component?

@castastrophe castastrophe added needs discussion needs to be discussed outside the PR needs: prioritization To be prioritized labels Apr 27, 2021
@starryeyez024
Copy link
Member

These list styles are already a part of pfe-styles, in the pfe-base.css:
https://patternflyelements.com/elements/pfe-styles/demo/

Unfortunately the way HTML works, you have one place to define padding which includes the space that the number lives in. This is good in the sense that it allows for right alignment of the numbers themselves.

image

I used these files for reference, but perhaps they could be modified to reflect how HTML works, @coreyvickery ?
https://xd.adobe.com/spec/3e62e93c-8338-4f31-5040-3b81f0ed5c71-4853/screen/9bb612e0-efbe-4881-b634-88767ba69344/specs/
https://xd.adobe.com/spec/3e62e93c-8338-4f31-5040-3b81f0ed5c71-4853/screen/294d086b-9c58-4612-be42-d833c4debda6/

And also verified visually that these line up:
image

@castastrophe
Copy link
Contributor

@starryeyez024 Do you think we can close this issue then if the styles already exist in pfe-styles or is there an implementation we're missing?

@coreyvickery
Copy link
Collaborator Author

@starryeyez024 Updated documentation with new images.

@starryeyez024
Copy link
Member

@coreyvickery can you share the link to what you're referring to, and feel free to weigh in on Cassondra's question if you think we need to nudge any spacing. Otherwise I'd call this good.

@castastrophe castastrophe removed the needs: prioritization To be prioritized label May 11, 2021
@coreyvickery
Copy link
Collaborator Author

@starryeyez024 Sorry, here is the artboard in XD. The mauve spacer is 48px.

Typography, list styles, desktop, light theme@2x

@coreyvickery
Copy link
Collaborator Author

@castastrophe Do you know if what exists in pfe-styles matches the above?

@castastrophe
Copy link
Contributor

@coreyvickery I'm not sure. I'll make a note to do an audit.

@starryeyez024
Copy link
Member

@coreyvickery
Copy link
Collaborator Author

@starryeyez024 @castastrophe The styles in the link above look good.

@castastrophe castastrophe changed the title [NEW] List styles [update] List style spacing, pfe-styles Jun 1, 2021
@castastrophe castastrophe added update component request fix and removed needs discussion needs to be discussed outside the PR feature New feature or request labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design specs complete design system Updates or issues to align components to the Red Hat Design System. fix update component request
Projects
None yet
Development

No branches or pull requests

3 participants