Add pull request template #226
Conversation
|
Haha! |
| ### Ready-for-merge Checklist | ||
|
|
||
| - [ ] Expected files: all files in the merge request related to one feature request? | ||
| - [ ] Is your branch up-to-date with the master branch? |
There was a problem hiding this comment.
This is automated, so I think we can get by without asking it directly. Branches cannot be merged if they aren't up to date, and github offers an "Update" button to do the update. The UI makes it clear that this is necessary.
There was a problem hiding this comment.
@mwcz ack, i'll update that too, i need to rename the file to get github to "see" it
|
|
||
| - [ ] Expected files: all files in the merge request related to one feature request? | ||
| - [ ] Is your branch up-to-date with the master branch? | ||
| - [ ] Did automated tests pass? |
There was a problem hiding this comment.
This is also automated, PRs cannot be merged unless tests are passing. I think we can get by without asking this directly as well, since UI answers it for us.
| - [ ] Did automated tests pass? | ||
| - [ ] Was it [browser-tested](https://docs.google.com/spreadsheets/d/1luriPYswlGcKdcbKhQfW6kxIgj7tjNjnBVP7yZ4onwA/edit#gid=1660273076)? | ||
| - [ ] Was this feature demo'd and the design review task marked as complete? | ||
| - [ ] Did it get a LGTM *after the last commit*? (changelog updates are exempt from this rule) |
There was a problem hiding this comment.
We can make this automated in the repo's merging settings, sounds like a really good idea to me.
There was a problem hiding this comment.
sweet, should i leave this checkbox in place until we automate it?
There was a problem hiding this comment.
@starryeyez024 Sorry for the delay! I already turned it on, so you can remove the checkbox. :)
No description provided.