Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): prefix input name attr, remove scope #2282

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fix(table): prefix input name attr, remove scope #2282

merged 1 commit into from
Sep 23, 2019

Conversation

mattnolting
Copy link
Contributor

fixes: #2165

@patternfly-build
Copy link

PatternFly-Next preview: https://patternfly-next-pr-2282.surge.sh

mcoker
mcoker approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass now.

@mcoker mcoker merged commit 283fe4b into patternfly:master Sep 23, 2019
@redallen
Copy link
Contributor

🎉 This PR is included in version 2.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

rachael-phillips added a commit that referenced this pull request Sep 27, 2019
@rachael-phillips
Update 2019.08 release notes (2019-10-01)
6c62401 
# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))
redallen pushed a commit that referenced this pull request Oct 1, 2019
@rachael-phillips @redallen
Update RELEASE-NOTES.md [ci skip] (#2306)
dc2f484 
* Create 2019.08 release notes (2019-10-01)

Adding new release notes

* Update 2019.08 release notes (2019-10-01)

# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))

* Rename 2019.08 release notes (2019-10-01) to 2019.08 release notes (2019-10-01).MD

Added .md file name

* Update 2019.08 release notes (2019-10-01).MD

Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com>

* alphabetize components
@mattnolting mattnolting deleted the fix-table-a11y-issues branch February 24, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattnolting @patternfly-build @redallen @mcoker