Skip to content

Commit

Permalink
fix(tree-list): deprecated due to mobx autorun issues
Browse files Browse the repository at this point in the history
Dropped the tree-list component due to additional issues with mobx autorun introduced by angular-tree-component.
  • Loading branch information
dlabrecq committed Jun 14, 2018
1 parent 54d234e commit 4bfd679
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
9 changes: 9 additions & 0 deletions src/app/list/tree-list/tree-list-config.ts
Expand Up @@ -2,6 +2,9 @@ import { ListBaseConfig } from '../list-base-config';

/**
* A config containing properties for tree list
*
* @deprecated Dropped the tree-list component due to Angular 6 issues with mobx autorun introduced by
* angular-tree-component.
*/
export class TreeListConfig extends ListBaseConfig {
/**
Expand All @@ -13,4 +16,10 @@ export class TreeListConfig extends ListBaseConfig {
* For angular-tree-component options, see: https://angular2-tree.readme.io/docs
*/
treeOptions?: any;

constructor() {
super();
console.log('patternfly-ng: The tree-list component is deprecated due to Angular 6 issues with mobx autorun ' +
'introduced by angular-tree-component.');
}
}
5 changes: 5 additions & 0 deletions src/app/list/tree-list/tree-list.component.ts
Expand Up @@ -34,6 +34,9 @@ import { TreeListConfig } from './tree-list-config';
*
* Or:
* <br/><code>import { TreeListModule } from 'patternfly-ng';</code>
*
* @deprecated Dropped the tree-list component due to Angular 6 issues with mobx autorun introduced by
* angular-tree-component.
*/
@Component({
encapsulation: ViewEncapsulation.None,
Expand Down Expand Up @@ -92,6 +95,8 @@ export class TreeListComponent extends ListBase implements DoCheck, OnInit {
*/
constructor() {
super();
console.log('patternfly-ng: The tree-list component is deprecated due to Angular 6 issues with mobx autorun ' +
'introduced by angular-tree-component.');
}

// Initialization
Expand Down
10 changes: 9 additions & 1 deletion src/app/list/tree-list/tree-list.module.ts
Expand Up @@ -13,6 +13,9 @@ export {

/**
* A module containing objects associated with tree list components
*
* @deprecated The tree-list component is deprecated due to Angular 6 issues with mobx autorun introduced by
* angular-tree-component.
*/
@NgModule({
imports: [
Expand All @@ -24,4 +27,9 @@ export {
declarations: [TreeListComponent],
exports: [TreeListComponent]
})
export class TreeListModule {}
export class TreeListModule {
constructor() {
console.log('patternfly-ng: The tree-list component is deprecated due to Angular 6 issues with mobx autorun ' +
'introduced by angular-tree-component.');
}
}

0 comments on commit 4bfd679

Please sign in to comment.