Skip to content

Commit

Permalink
fix(tree-list): deprecated for Angular 6 compatibility (#376)
Browse files Browse the repository at this point in the history
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes #381
  • Loading branch information
dlabrecq committed Jun 18, 2018
1 parent d3083ac commit cfe146f
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 2 deletions.
@@ -1,7 +1,7 @@
<div class="padding-15">
<div class="row">
<div class="col-sm-12">
<h4>Tree List Component Example</h4>
<h4>Tree List Component Example (deprecated)</h4>
<hr/>
</div>
</div>
Expand Down
5 changes: 5 additions & 0 deletions src/app/list/tree-list/tree-list-config.ts
Expand Up @@ -2,6 +2,11 @@ import { ListConfigBase } from '../list-config-base';

/**
* A config containing properties for tree list
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
export class TreeListConfig extends ListConfigBase {
/**
Expand Down
5 changes: 5 additions & 0 deletions src/app/list/tree-list/tree-list.component.ts
Expand Up @@ -34,6 +34,11 @@ import { TreeListConfig } from './tree-list-config';
*
* Or:
* <br/><code>import { TreeListModule } from 'patternfly-ng';</code>
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
@Component({
encapsulation: ViewEncapsulation.None,
Expand Down
12 changes: 11 additions & 1 deletion src/app/list/tree-list/tree-list.module.ts
Expand Up @@ -9,6 +9,11 @@ import { TreeListComponent } from './tree-list.component';

/**
* A module containing objects associated with tree list components
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
@NgModule({
imports: [
Expand All @@ -20,4 +25,9 @@ import { TreeListComponent } from './tree-list.component';
declarations: [TreeListComponent],
exports: [TreeListComponent]
})
export class TreeListModule {}
export class TreeListModule {
constructor() {
console.log('patternfly-ng: The tree-list component is deprecated due to issues with Angular 6 and ' +
'mobx autorun, introduced by angular-tree-component.');
}
}

0 comments on commit cfe146f

Please sign in to comment.