Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate tree list #381

Closed
dlabrecq opened this issue Jun 15, 2018 · 0 comments
Closed

Deprecate tree list #381

dlabrecq opened this issue Jun 15, 2018 · 0 comments

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Jun 15, 2018 •
edited

Deprecate the tree-list component in anticipation of Angular 6 support. This decision was made due to additional issues with mobx autorun introduced by angular-tree-component.

If angular-tree-component resolves the issue below, it's possible we could reintroduce the tree-list component. However, this particular issue should not prevent patternfly-ng from supporting Angular 6.

See: CirclonGroup/angular-tree-component#596
This was referenced Jun 15, 2018
Merged
Merged
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 15, 2018
@dlabrecq
fix(tree-list): deprecated due to mobx autorun issues
54810b2 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 17, 2018
@dlabrecq
fix(tree-list): deprecated due to mobx autorun issues
697c8b3 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 17, 2018
@dlabrecq
fix(tree-list): deprecated for Angular 6 compatibility
9c644c4 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 18, 2018
@dlabrecq
fix(tree-list): deprecated for Angular 6 compatibility
50cdc57 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 18, 2018
@dlabrecq
fix(tree-list): deprecated for Angular 6 compatibility
0a48c55 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes patternfly#381
dlabrecq added a commit that referenced this issue Jun 18, 2018
@dlabrecq
fix(tree-list): deprecated for Angular 6 compatibility (#376)
cfe146f 
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes #381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 19, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
f8db562 
… 13, rxjs 6, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 20, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
8bdebc9 
… 13, rxjs 6, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 25, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
00c361c 
… 13, rxjs 6, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 28, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
c35840d 
… 13, rxjs 6, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 30, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
e46e0e5 
… 13, rxjs 6, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381

Removed deprecations
See https://github.com/patternfly/patternfly-ng/releases for details

- NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem
- NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
- PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule
- NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule
- ListModule: Use TreeListModule and ListModule for basic list only
- ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig
- ChartModule: Use DonutChartModule and SparklineChartModule
- DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig
- SparklineComponent: Use SparklineChartComponent
- SparklineConfig: Use SparklineChartConfig
- SparklineData: Use SparklineChartData
- CardModule: Use InfoStatusCardModule and CardModule for basic card only
- ModalModule: Use AboutModal
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 30, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
f09c10b 
… 13, rxjs 6, gulp 4, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381

Removed deprecations

- NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem
- NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
- PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule
- NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule
- ListModule: Use TreeListModule and ListModule for basic list only
- ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig
- ChartModule: Use DonutChartModule and SparklineChartModule
- DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig
- SparklineComponent: Use SparklineChartComponent
- SparklineConfig: Use SparklineChartConfig
- SparklineData: Use SparklineChartData
- CardModule: Use InfoStatusCardModule and CardModule for basic card only
- ModalModule: Use AboutModal
dlabrecq added a commit to dlabrecq/patternfly-ng that referenced this issue Jun 30, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
2b616ae 
… 13, rxjs 6, gulp 4, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381

Removed deprecations

- NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem
- NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
- PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule
- NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule
- ListModule: Use TreeListModule and ListModule for basic list only
- ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig
- ChartModule: Use DonutChartModule and SparklineChartModule
- DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig
- SparklineComponent: Use SparklineChartComponent
- SparklineConfig: Use SparklineChartConfig
- SparklineData: Use SparklineChartData
- CardModule: Use InfoStatusCardModule and CardModule for basic card only
- ModalModule: Use AboutModal
dlabrecq added a commit that referenced this issue Jun 30, 2018
@dlabrecq
BREAKING CHANGE: updated to Angular 6, ngx-bootstrap 3, ngx-datatable…
888dc06 
… 13, rxjs 6, gulp 4, and webpack 4 (#359)

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component -- see #381

Removed 3.x deprecations in favor of individual module imports

- NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem
- NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
- PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule
- NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule
- ListModule: Use TreeListModule and ListModule for basic list only
- ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig
- ChartModule: Use DonutChartModule and SparklineChartModule
- DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig
- SparklineComponent: Use SparklineChartComponent
- SparklineConfig: Use SparklineChartConfig
- SparklineData: Use SparklineChartData
- CardModule: Use InfoStatusCardModule and CardModule for basic card only
- ModalModule: Use AboutModal
@corinnekrych corinnekrych mentioned this issue Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dlabrecq