Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 6 support #359

Merged
merged 1 commit into from Jun 30, 2018
Merged

Angular 6 support #359

merged 1 commit into from Jun 30, 2018

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented May 22, 2018

DO NOT MERGE: BREAKING CHANGE

Updated to Angular 6, ngx-bootstrap 3.0.0, ngx-datatable 13.0.0, rxjs 6, gulp 4, and webpack 4

Dropped the tree-list component due to additional issues with mobx autorun introduced by angular-tree-component.
See: #381

Note: Karma won't run without typescript 2.8.1, while Angular 6 requires 2.7.2.
See: https://stackoverflow.com/questions/49468616/cannot-read-property-externalmoduleindicator-of-undefined-while-running-unit-t

@dlabrecq dlabrecq mentioned this pull request May 22, 2018
@dlabrecq dlabrecq changed the title WIP: updated to Angular 6... WIP: Angular 6 support May 22, 2018
@dlabrecq dlabrecq force-pushed the angular6 branch 2 times, most recently from 0e2df24 to 7b4f5bb Compare May 23, 2018 15:37
@seanforyou23
Copy link
Contributor

Note: Karma won't run without typescript 2.8.1, while Angular 6 requires 2.7.2.

I found that by replacing awesome-typescript-loader with ts-loader, karma is able to start while using typescript 2.7.2

@dlabrecq
Copy link
Member Author

dlabrecq commented Jun 6, 2018

Replaced awesome-typescript-loader with ts-loader -- unit tests run as expected now.

@dlabrecq dlabrecq force-pushed the master branch 2 times, most recently from 6d9f1f7 to 596afce Compare June 17, 2018 14:49
@dlabrecq dlabrecq force-pushed the angular6 branch 3 times, most recently from 8e5841c to 24c79bc Compare June 25, 2018 17:30
@dlabrecq
Copy link
Member Author

dlabrecq commented Jun 26, 2018

Replaced extract-text-webpack-plugin with mini-css-extract-plugin. The extract-text-webpack-plugin simply does not work with webpack 4 and prevents the demo from being able to watch for code changes.

The mini-css-extract-plugin is compatible with webpack 4 and restores the demo's ability to watch for updates. Unfortunately, I had to temporarily disable AOT for the demo because mini-css-extract-plugin has an issue with AngularCompilerPlugin.

See: webpack-contrib/mini-css-extract-plugin#186

@dlabrecq
Copy link
Member Author

Updated to gulp 4 and added an AOT build. This means the build will be much quicker because we don't need to run the demo just to test AOT.

… 13, rxjs 6, gulp 4, and webpack 4

Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component.
See patternfly#381

Removed deprecations

- NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem
- NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
- PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule
- NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule
- ListModule: Use TreeListModule and ListModule for basic list only
- ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig
- ChartModule: Use DonutChartModule and SparklineChartModule
- DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig
- SparklineComponent: Use SparklineChartComponent
- SparklineConfig: Use SparklineChartConfig
- SparklineData: Use SparklineChartData
- CardModule: Use InfoStatusCardModule and CardModule for basic card only
- ModalModule: Use AboutModal
@dlabrecq dlabrecq changed the title WIP: Angular 6 support Angular 6 support Jun 30, 2018
@dlabrecq dlabrecq merged commit 888dc06 into patternfly:master Jun 30, 2018
@dlabrecq dlabrecq mentioned this pull request Jun 30, 2018
@dlabrecq dlabrecq deleted the angular6 branch June 30, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants