New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 6 support #359
Angular 6 support #359
Conversation
0e2df24
to
7b4f5bb
Compare
I found that by replacing |
Replaced awesome-typescript-loader with ts-loader -- unit tests run as expected now. |
6d9f1f7
to
596afce
Compare
8e5841c
to
24c79bc
Compare
Replaced extract-text-webpack-plugin with mini-css-extract-plugin. The extract-text-webpack-plugin simply does not work with webpack 4 and prevents the demo from being able to watch for code changes. The mini-css-extract-plugin is compatible with webpack 4 and restores the demo's ability to watch for updates. Unfortunately, I had to temporarily disable AOT for the demo because mini-css-extract-plugin has an issue with AngularCompilerPlugin. |
Updated to gulp 4 and added an AOT build. This means the build will be much quicker because we don't need to run the demo just to test AOT. |
… 13, rxjs 6, gulp 4, and webpack 4 Dropped the tree-list component due to Angular 6 issues with mobx autorun, introduced by angular-tree-component. See patternfly#381 Removed deprecations - NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem - NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule - PipeModule: Use SearchHighlightModule, SortArrayModule, or TruncateModule - NotificationModule: Use InlineNotificationModule, NotificationDrawerModule, NotificationServiceModule, ToastNotificationModule, or ToastNotificationListModule - ListModule: Use TreeListModule and ListModule for basic list only - ChartConfig: Use ChartConfigBase, DonutChartConfig, or SparklineChartConfig - ChartModule: Use DonutChartModule and SparklineChartModule - DonutConfig: Use DonutChartConfig or UtilizationDonutChartConfig - SparklineComponent: Use SparklineChartComponent - SparklineConfig: Use SparklineChartConfig - SparklineData: Use SparklineChartData - CardModule: Use InfoStatusCardModule and CardModule for basic card only - ModalModule: Use AboutModal
DO NOT MERGE: BREAKING CHANGE
Updated to Angular 6, ngx-bootstrap 3.0.0, ngx-datatable 13.0.0, rxjs 6, gulp 4, and webpack 4
Dropped the tree-list component due to additional issues with mobx autorun introduced by angular-tree-component.
See: #381
Note: Karma won't run without typescript 2.8.1, while Angular 6 requires 2.7.2.See: https://stackoverflow.com/questions/49468616/cannot-read-property-externalmoduleindicator-of-undefined-while-running-unit-t