Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerticalNavigationComponent doesn't close secondary on click #372

Closed
ssilvert opened this issue Jun 5, 2018 · 4 comments · Fixed by #396
Closed

VerticalNavigationComponent doesn't close secondary on click #372

ssilvert opened this issue Jun 5, 2018 · 4 comments · Fixed by #396

Comments

@ssilvert
Copy link

ssilvert commented Jun 5, 2018

The PatternFly VerticalNavigation shows that when you click an item in a secondary menu then the menu will immediately close. I can't find a way to make this happen with the component.

@dlabrecq
Copy link
Member

dlabrecq commented Jun 7, 2018

Talking with @dgutride and it sounds like the menu is expected to be dismissed after you route to a new page. Are you navigating somewhere when the menu option is clicked?

The URL defined in the vertical nav config should match a path defined in your routing module.

@dlabrecq
Copy link
Member

If you have further questions, please join our patternfly-ng channel on Slack

@ssilvert
Copy link
Author

ssilvert commented Jun 21, 2018

Hi Dan. Didn't find you on slack.

I do navigate when the menu option is clicked. A new page is loaded into the <router-outlet>. However, the secondary navigation still does not close unless you hover or click outside the navigation and then wait a few seconds. It should close as soon as you click the secondary option.

I think this should probably be reopened.

@dlabrecq
Copy link
Member

I agree. The menu should be dismissed immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants