Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical-nav: close secondary and tertiary menus upon leaf node click #396

Merged
merged 1 commit into from Jun 22, 2018

Conversation

dlabrecq
Copy link
Member

This change closes the secondary and tertiary menus upon leaf node click. Otherwise, the user must hover or click outside the navigation area, then wait a couple seconds for the menu to dismiss.

Fixes #372

FYI @ssilvert

@dlabrecq dlabrecq changed the title vertical-nav: close secondary and tertiary menus upon leaf node … WIP vertical-nav: close secondary and tertiary menus upon leaf node click Jun 21, 2018
@dlabrecq dlabrecq changed the title WIP vertical-nav: close secondary and tertiary menus upon leaf node click vertical-nav: close secondary and tertiary menus upon leaf node click Jun 21, 2018
@ssilvert
Copy link

@dlabrecq Thanks!

@dlabrecq dlabrecq merged commit 3117934 into patternfly:master Jun 22, 2018
@dlabrecq dlabrecq deleted the vertical-nav-menu branch June 25, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerticalNavigationComponent doesn't close secondary on click
2 participants