chore(info-card): clean up info card example #190
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,47 @@ | ||
| <div class="row"> | ||
| <div class="col-xs-12"> | ||
| <h4>Info Card Component Example</h4> | ||
| <hr/> | ||
| </div> | ||
| </div> | ||
| <div class="padding-15"> | ||
| <div class="row row-cards-pf well"> | ||
| <div style="max-width:409px;"> | ||
| <div class="col-md-10"> | ||
|
There was a problem hiding this comment. Change this to |
||
| <label>With top border, Icon Class, Href</label> | ||
| <pfng-info-status-card | ||
| [config]="card1Config"> | ||
| </pfng-info-status-card> | ||
| <br> | ||
|
There was a problem hiding this comment. Instead of using |
||
| <label>No Top Border, Icon Image, No Title, No Html Content</label> | ||
| <pfng-info-status-card | ||
| [config]="card2Config"> | ||
| </pfng-info-status-card> | ||
| <br> | ||
| <label>With HTML</label> | ||
| <pfng-info-status-card | ||
| [config]="card3Config"> | ||
| </pfng-info-status-card> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="row padding-bottom-15 padding-top-15"> | ||
| <div class="col-xs-12"> | ||
| <h4>Code</h4> | ||
| <hr/> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <tabset> | ||
| <tab heading="api"> | ||
| <iframe class="demoframe" src="docs/classes/cardcomponent.html"></iframe> | ||
| </tab> | ||
| <tab heading="html"> | ||
| <include-content src="src/app/card/info-status-card/examples/info-status-card-example.component.html"></include-content> | ||
| </tab> | ||
| <tab heading="typescript"> | ||
| <include-content src="src/app/card/info-status-card/examples/info-status-card-example.component.ts"></include-content> | ||
| </tab> | ||
| </tabset> | ||
| </div> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is conflicting with the column width that you have set below. In the "medium" viewport, you are making the card smaller than the column wants it to be.
I would delete this line, and change the column styles on the next. (see below)