Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applies font awesome's fixed-width class to the 'angle' icon in the basic list component #401

Merged
merged 1 commit into from Jun 27, 2018

Conversation

brimwd
Copy link
Contributor

@brimwd brimwd commented Jun 26, 2018

https://fontawesome.com/v4.7.0/examples/#fixed-width

This makes the font awesome icons a uniform width, so when the icon changes from angle-right to angle-down the adjacent label doesn't shift position.

https://fontawesome.com/v4.7.0/examples/#fixed-width

This makes the font awesome icons a uniform width, so when the icon changes from `angle-right` to `angle-down` the adjacent label doesn't shift position.
@brimwd brimwd changed the title applies font awesome's fixed-width class to the 'angle' applies font awesome's fixed-width class to the 'angle' icon in the basic list component Jun 26, 2018
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out locally and it looks good to me. Thanks for the fix!

@dlabrecq dlabrecq merged commit d2e6fb6 into patternfly:master Jun 27, 2018
@brimwd brimwd deleted the patch-1 branch June 27, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants