fix(filter): Removed placeholder from within dropdown…

[dtaylor113]

… and show current value in dropdown

Before:

• Placeholder text within dropdown
• Selected/Applied filter value not reflected in dropdown
  

After:

• Placeholder text removed from dropdown
• Selected/Applied filter value reflected in dropdown
• Dropdown remembers previously applied filter value
  

CC @mcarrano, @akaRem

Fixes #418

[patternfly-build]

Deploy preview for patternfly-ng ready!

Built with commit 0bc3664

https://deploy-preview-449--patternfly-ng.netlify.com

[mcarrano]

@dtaylor113 This looks promising. But I cannot seem to get to the preview link. Can you check it?

[dlabrecq]

@mcarrano Try the link again. It worked for me, but takes a bit to load

[mcarrano]

This looks great, @dtaylor113 . My only question is whether it can be made so that the text is only italicized when it is the placeholder. At all other times, the selection should not be italicized. If this is not possible, then I think I would remove the italicized style altogether.

As for the multi-select variant we talked about yesterday, here is a quick mockup to show what this could look like. Let me know what you think.

[dtaylor113]

I was thinking the same thing @mcarrano :-) Here's the updated screenshots:

[dlabrecq]

@mcarrano I may have encountered an issue with the pattern.

1. Choose a birth month option -- the selection is shown in the menu
2. Now change the filter field from Birth Month to Name
3. Change the filter field back to Birth Month

Although the filter has been applied, the filter selection is no longer reflected in the menu. Wondering if the menu selection is expected to reflect the applied filter in this scenario?

[dtaylor113]

Although the filter has been applied, the filter selection is no longer reflected in the menu

Hi @dlabrecq, I raised this in the middle of patternfly/patternfly#1116. I'm still not sure how complicated it will be to have the dropdown remember it's state -especially if we eventually support multiple select values. It also depends on whether we also support enforcing single select or allow dropdown filters to be accumulative.

I'll spend a little more time looking into this issue. I think for now we are always enforcing single select/applied filter for dropdowns. Meaning a dropdown always replaces an existing filter tag. In this scenario it makes sense to reset the dropdown to the applied filter value.

[dtaylor113]

@mcarrano, @dlabrecq Dropdowns now remember previously applied filter values. I've updated this PRs Description and screenshots to show this. -thanks

[mcarrano]

This is looking good @dtaylor113 Do you want to try to incorporate the multi-select here also or would you rather consider that in a separate PR?

[dtaylor113]

This is looking good @dtaylor113 Do you want to try to incorporate the multi-select here also or would you rather consider that in a separate PR?

Separate PR please! I need to apply these changes to patternfly-react next, then I'd work on multi-select. -thanks

@mcarrano, @dlabrecq please approve this PR when/if ready -thanks

[dlabrecq]

LGTM

[mcarrano]

Looks great @dtaylor113 . I will open a separate issue for the multi-select version of this control.

[dtaylor113]

I will open a separate issue for the multi-select version of this control.

Thanks @mcarrano, please be sure to indicate that multi-select should use 'Grouped Filter Chips'.

[patternfly-build]

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀