Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 162 update to react 18 and pf5 #164

Merged
merged 20 commits into from
Sep 7, 2023
Merged

chore: 162 update to react 18 and pf5 #164

merged 20 commits into from
Sep 7, 2023

Conversation

gitdallas
Copy link
Contributor

No description provided.

@gitdallas gitdallas marked this pull request as draft July 10, 2023 19:15
@gitdallas
Copy link
Contributor Author

Need to get rid of enzyme and react-router-dom

@nicolethoen nicolethoen linked an issue Aug 4, 2023 that may be closed by this pull request
Update to React 18 & PF 5 #162
Closed
4 tasks
@nicolethoen nicolethoen marked this pull request as ready for review August 21, 2023 17:37
jenny-s51
jenny-s51 reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component updates look good but it looks like some styles and fonts are missing

Before:
Screenshot 2023-08-21 at 2 19 13 PM

After:
Screenshot 2023-08-21 at 2 21 48 PM

jenny-s51
jenny-s51 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM following latest changes!

nicolethoen
nicolethoen reviewed Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kinds of errors does npm install produce that force us to need to use npm install --force?

@gitdallas
Copy link
Contributor Author

@nicolethoen - it wasn't allowing me to install without it. i know there have been changes with npm install over the past couple versions that make it so it will exit out on things that it previously wouldn't have without the force.

i'm unsure if this has changed since i first worked on this pr.. i'll check.

jenny-s51
jenny-s51 reviewed Sep 7, 2023
View reviewed changes
test-setup.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this unused file @gitdallas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, it looks like some remnants of enzyme.

@gitdallas
Copy link
Contributor Author

I was able to run npm install without force and get things up and running, so I believe it should be okay to remove. Also appears that the ci has no issue

jenny-s51
jenny-s51 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gitdallas - LGTM

@nicolethoen nicolethoen merged commit 5229262 into patternfly:main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@jenny-s51 jenny-s51 jenny-s51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to React 18 & PF 5
5 participants
@gitdallas @wise-king-sullyman @nicolethoen @jenny-s51 @mfrances17