Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update patternfly deps to v6 alphas #197

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

evwilkin
Copy link
Collaborator

Bumps versions:

"@patternfly/react-core": "6.0.0-alpha.19",
"@patternfly/react-icons": "6.0.0-alpha.9",
"@patternfly/react-styles": "6.0.0-alpha.9"

Fixes type errors thrown in Nav && EmptyState components due to changes in these components in newer versions.

@evwilkin evwilkin requested review from nicolethoen and tlabaj and removed request for nicolethoen and tlabaj January 23, 2024 17:18
@evwilkin evwilkin marked this pull request as draft January 23, 2024 17:20
@evwilkin
Copy link
Collaborator Author

@tlabaj I need to update snapshots with the new alpha version bump for Nav no longer having the theme prop as well as the pf-m-expandable class being removed as seen in your PR.

In checking before updating the snapshot, the theme prop is straightforward but I'm having trouble confirming that the pf-m-expandable is something that should be removed, as it looks to still be on the Core markup. Do you mind taking a look to confirm that this class should be dropped?

@tlabaj
Copy link
Collaborator

tlabaj commented Jan 24, 2024

@tlabaj I need to update snapshots with the new alpha version bump for Nav no longer having the theme prop as well as the pf-m-expandable class being removed as seen in your PR.

In checking before updating the snapshot, the theme prop is straightforward but I'm having trouble confirming that the pf-m-expandable is something that should be removed, as it looks to still be on the Core markup. Do you mind taking a look to confirm that this class should be dropped?

I believe core examples need to be updated. The pf-m-expandable modifier no longer exists in the style sheet so I talked to @mattnolting and removed it in React.

@tlabaj
Copy link
Collaborator

tlabaj commented Jan 24, 2024

@evwilkin @mattnolting I opened this core issue patternfly/patternfly#6248

@evwilkin evwilkin marked this pull request as ready for review January 31, 2024 16:57
@evwilkin evwilkin merged commit b3dc39a into patternfly:v6 Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants