Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update patternfly deps to v6 alphas #197

Merged
merged 2 commits into from
Feb 5, 2024
Merged

chore(deps): update patternfly deps to v6 alphas #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e90d81
chore(docs): bump to latest alpha versions, updates to Nav & EmptyState
evwilkin Jan 23, 2024
b3dc39a
update snapshot
evwilkin Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@
"webpack-merge": "^5.9.0"
},
"dependencies": {
"@patternfly/react-core": "6.0.0-alpha.7",
"@patternfly/react-icons": "6.0.0-alpha.5",
"@patternfly/react-styles": "6.0.0-alpha.5",
"@patternfly/react-core": "6.0.0-alpha.19",
"@patternfly/react-icons": "6.0.0-alpha.9",
"@patternfly/react-styles": "6.0.0-alpha.9",
"@storybook/builder-webpack5": "^7.5.3",
"react": "^18",
"react-dom": "^18",
Expand Down
2 changes: 1 addition & 1 deletion src/app/AppLayout/AppLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const AppLayout: React.FunctionComponent<IAppLayout> = ({ children }) => {
);

const Navigation = (
<Nav id="nav-primary-simple" theme="light">
<Nav id="nav-primary-simple">
<NavList id="nav-list-simple">
{routes.map(
(route, idx) => route.label && (!route.routes ? renderNavItem(route, idx) : renderNavGroup(route, idx))
Expand Down
17 changes: 7 additions & 10 deletions src/app/NotFound/NotFound.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import {
EmptyState,
EmptyStateBody,
EmptyStateFooter,
EmptyStateHeader,
EmptyStateIcon,
PageSection,
} from '@patternfly/react-core';
import { useHistory } from 'react-router-dom';
Expand All @@ -24,14 +22,13 @@ const NotFound: React.FunctionComponent = () => {

return (
<PageSection>
<EmptyState variant="full">
<EmptyStateHeader titleText="404 Page not found" icon={<EmptyStateIcon icon={ExclamationTriangleIcon} />} headingLevel="h1" />
<EmptyStateBody>
We didn&apos;t find a page that matches the address you navigated to.
</EmptyStateBody><EmptyStateFooter>
<GoHomeBtn />
</EmptyStateFooter></EmptyState>
</PageSection>
<EmptyState titleText="404 Page not found" variant="full" icon={ExclamationTriangleIcon} >
<EmptyStateBody>
We didn&apos;t find a page that matches the address you navigated to.
</EmptyStateBody><EmptyStateFooter>
<GoHomeBtn />
</EmptyStateFooter></EmptyState>
</PageSection>
)
};

Expand Down
5 changes: 1 addition & 4 deletions src/app/Support/Support.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import {
EmptyStateActions,
EmptyStateBody,
EmptyStateFooter,
EmptyStateHeader,
EmptyStateIcon,
EmptyStateVariant,
PageSection,
Text,
Expand All @@ -22,8 +20,7 @@ export interface ISupportProps {
// eslint-disable-next-line prefer-const
let Support: React.FunctionComponent<ISupportProps> = () => (
<PageSection>
<EmptyState variant={EmptyStateVariant.full}>
<EmptyStateHeader titleText="Empty State (Stub Support Module)" icon={<EmptyStateIcon icon={CubesIcon} />} headingLevel="h1" />
<EmptyState variant={EmptyStateVariant.full} titleText="Empty State (Stub Support Module)" icon={CubesIcon} >
<EmptyStateBody>
<TextContent>
<Text component="p">
Expand Down
4 changes: 2 additions & 2 deletions src/app/__snapshots__/app.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ exports[`App tests should render default App component 1`] = `
>
<nav
aria-label="Global"
class="pf-v5-c-nav pf-m-light"
class="pf-v5-c-nav"
data-ouia-component-id="OUIA-Generated-Nav-1"
data-ouia-component-type="PF5/Nav"
data-ouia-safe="true"
Expand Down Expand Up @@ -194,7 +194,7 @@ exports[`App tests should render default App component 1`] = `
</a>
</li>
<li
class="pf-v5-c-nav__item pf-m-expandable"
class="pf-v5-c-nav__item"
data-ouia-component-id="OUIA-Generated-NavExpandable-1"
data-ouia-component-type="PF5/NavExpandable"
data-ouia-safe="true"
Expand Down
Loading