feat(Button): rename linkPosition > iconPosition, update example

patternfly · Mar 2, 2020 · 279820b · 279820b
1 parent cfdb9b3
commit 279820b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/patternfly-4/react-core/src/components/Button/Button.tsx b/packages/patternfly-4/react-core/src/components/Button/Button.tsx
@@ -43,7 +43,7 @@ export interface ButtonProps extends React.HTMLProps<HTMLButtonElement> {
   /** Adds button variant styles */
   variant?: 'primary' | 'secondary' | 'tertiary' | 'danger' | 'link' | 'plain' | 'control';
   /** Sets position of the link icon */
-  linkPosition?: 'left' | 'right';
+  iconPosition?: 'left' | 'right';
   /** Adds accessible text to the button. */
   'aria-label'?: string;
   /** Icon for the button if variant is a link */
@@ -64,7 +64,7 @@ const Button: React.FunctionComponent<ButtonProps & InjectedOuiaProps> = ({
   isInline = false,
   type = ButtonType.button,
   variant = ButtonVariant.primary,
-  linkPosition = 'left',
+  iconPosition = 'left',
   'aria-label': ariaLabel = null,
   icon = null,
   ouiaContext = null,
@@ -98,12 +98,12 @@ const Button: React.FunctionComponent<ButtonProps & InjectedOuiaProps> = ({
         'data-ouia-component-id': ouiaId || ouiaContext.ouiaId
       })}
     >
-      {icon && variant === ButtonVariant.link && linkPosition === 'left' && (
+      {icon && variant === ButtonVariant.link && iconPosition === 'left' && (
         <span className="pf-c-button__icon">{icon}</span>
       )}
       {variant === ButtonVariant.link && <span className={css(styles.buttonText)}>{children}</span>}
       {variant !== ButtonVariant.link && children}
-      {icon && variant === ButtonVariant.link && linkPosition === 'right' && (
+      {icon && variant === ButtonVariant.link && iconPosition === 'right' && (
         <span className="pf-c-button__icon">{icon}</span>
       )}
     </Component>

diff --git a/packages/patternfly-4/react-core/src/components/Button/examples/Button.md b/packages/patternfly-4/react-core/src/components/Button/examples/Button.md
@@ -7,7 +7,7 @@ propComponents: ['Button']
 ---
 
 import { Button } from '@patternfly/react-core';
-import { TimesIcon, PlusCircleIcon } from '@patternfly/react-icons';
+import { TimesIcon, PlusCircleIcon, ExternalLinkSquareAltIcon } from '@patternfly/react-icons';
 
 ## Examples
 
@@ -22,7 +22,7 @@ BlockButton = () => <Button isBlock>Block level button</Button>;
 ```js title=Variations
 import React from 'react';
 import { Button } from '@patternfly/react-core';
-import { TimesIcon, PlusCircleIcon } from '@patternfly/react-icons';
+import { TimesIcon, PlusCircleIcon, ExternalLinkSquareAltIcon } from '@patternfly/react-icons';
 
 ButtonVariants = () => (
   <React.Fragment>
@@ -32,7 +32,7 @@ ButtonVariants = () => (
     <Button variant="link" icon={<PlusCircleIcon />}>
       Link button
     </Button>{' '}
-    <Button variant="link" icon={<PlusCircleIcon />} linkPosition="right">
+    <Button variant="link" icon={<ExternalLinkSquareAltIcon />} iconPosition="right">
       Link button
     </Button>{' '}
     <Button variant="plain" aria-label="Action">