fix(dropdown): add focus trap option that allows close on click

patternfly · Jan 4, 2019 · aef16d5 · aef16d5
1 parent 8e0f86e
commit aef16d5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/patternfly-4/react-core/src/components/Dropdown/DropdownMenu.js b/packages/patternfly-4/react-core/src/components/Dropdown/DropdownMenu.js
@@ -45,7 +45,9 @@ const DropdownMenu = ({ className, isOpen, position, children, component: Compon
     );
   } else if (Component === 'ul') {
     menu = (
-      <FocusTrap>
+      <FocusTrap focusTrapOptions={{
+        clickOutsideDeactivates: true
+      }}>
         <Component
           {...props}
           className={css(

diff --git a/packages/patternfly-4/react-core/src/components/Dropdown/__snapshots__/Dropdown.test.js.snap b/packages/patternfly-4/react-core/src/components/Dropdown/__snapshots__/Dropdown.test.js.snap
@@ -696,7 +696,11 @@ exports[`KebabToggle expanded 1`] = `
       <FocusTrap
         _createFocusTrap={[Function]}
         active={true}
-        focusTrapOptions={Object {}}
+        focusTrapOptions={
+          Object {
+            "clickOutsideDeactivates": true,
+          }
+        }
         paused={false}
         tag="div"
       >
@@ -2103,7 +2107,11 @@ exports[`dropdown expanded 1`] = `
       <FocusTrap
         _createFocusTrap={[Function]}
         active={true}
-        focusTrapOptions={Object {}}
+        focusTrapOptions={
+          Object {
+            "clickOutsideDeactivates": true,
+          }
+        }
         paused={false}
         tag="div"
       >