Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - ChartLegendTooltip - Title prop has wrong type #10128

Closed
dlabrecq opened this issue Mar 5, 2024 · 0 comments · Fixed by #10129
Closed

Bug - ChartLegendTooltip - Title prop has wrong type #10128

dlabrecq opened this issue Mar 5, 2024 · 0 comments · Fixed by #10129
Assignees
Labels

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Mar 5, 2024

We recently updated a few components to match Victory's latest type updates. Now the title prop of ChartLegendTooltip incorrectly uses type string, which is inherited from VictoryLabelProps.

This title prop is actually used with VictroyLabel, so it should match the VictoryLabelProps type; string[] | StringOrNumberOrCallback.

As a workaround in Cost Management, I can cast to any. For example, title={(datum => datum.x) as any}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant