New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make github and google drive icons available #1666

Closed

srambach opened this issue Apr 1, 2019 · 1 comment · Fixed by #1669

Member

srambach commented Apr 1, 2019

Please add the github and google drive icons for use.
https://fontawesome.com/icons/github?style=brands
https://fontawesome.com/icons/google-drive?style=brands

Also, there's a typo "fortawesome" in this file :-) https://github.com/patternfly/patternfly-react/blob/master/packages/react-icons/README.md

Contributor

karelhala commented Apr 1, 2019

We should include all brand icons, last time I tried it failed with 500px icon (this requires change after import), but other should be fine.

karelhala mentioned this issue

feat(Icons): Add font awesome brands icons #1669

Merged

dlabaj closed this as completed in #1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment