Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page: make mainContainerId prop required #2597

Closed
tlabaj opened this issue Jul 26, 2019 · 4 comments
Closed

Page: make mainContainerId prop required #2597

tlabaj opened this issue Jul 26, 2019 · 4 comments
Assignees
@kmcfaul
Labels
breaking change 💥 this change requires a major release and has API changes. enhancement 🚀 on hold PF4 React issues for the PF4 core effort
Milestone
2020.04

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jul 26, 2019

The mainContainerId prop should be required for the skip to content to function as expected.

cc @seanforyou23
@tlabaj tlabaj added enhancement 🚀 PF4 React issues for the PF4 core effort breaking change 💥 this change requires a major release and has API changes. labels Jul 26, 2019
@tlabaj tlabaj mentioned this issue Jul 26, 2019
Merged
@seanforyou23 seanforyou23 mentioned this issue Jul 26, 2019
Closed
@rachael-phillips rachael-phillips added this to the Breaking Changes milestone Aug 29, 2019
@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Oct 28, 2019
@stale stale bot closed this as completed Nov 11, 2019
@tlabaj tlabaj reopened this Nov 14, 2019
@stale stale bot removed the wontfix label Nov 14, 2019
@stale
Copy link

stale bot commented Jan 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 13, 2020
@tlabaj tlabaj removed the wontfix label Jan 21, 2020
@tlabaj tlabaj modified the milestones: Breaking Changes, 2020.04 Feb 5, 2020
@kmcfaul kmcfaul self-assigned this Mar 10, 2020
@kmcfaul kmcfaul mentioned this issue Mar 11, 2020
Merged
@tlabaj
Copy link
Contributor Author

tlabaj commented Mar 25, 2020

closed by #3904

@tlabaj tlabaj closed this as completed Mar 25, 2020
@redallen
Copy link
Contributor

redallen commented May 27, 2020 •
edited
Loading

Related: #2519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
breaking change 💥 this change requires a major release and has API changes. enhancement 🚀 on hold PF4 React issues for the PF4 core effort
Projects
None yet
Milestone
2020.04
Development

No branches or pull requests
4 participants
@tlabaj @rachael-phillips @kmcfaul @redallen