Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4 Possible bug on empty state size class binding #2680

Closed
carlosga opened this issue Aug 10, 2019 · 4 comments · Fixed by #2692
Closed

PF4 Possible bug on empty state size class binding #2680

carlosga opened this issue Aug 10, 2019 · 4 comments · Fixed by #2692
Assignees
Labels
PF4 React issues for the PF4 core effort

Comments

@carlosga
Copy link

Looking at the demo page of the Empty State component ( https://www.patternfly.org/v4/documentation/react/components/emptystate/ ) it looks like the css class for the component size is not being generated correctly, on the demo page, the small size one is being generated as 'styles.modifiers.sm' and the large one as 'styles.modifiers.lg', if i'm not wrong they should be generated as 'pf-m-sm' and 'pf-m-lg' ( as in the HTML demo page ).

@boaz0
Copy link
Member

boaz0 commented Aug 11, 2019

@carlosga you're right it is a bug.

@rachael-phillips rachael-phillips added PF4 React issues for the PF4 core effort bug 🐛 labels Aug 12, 2019
@rachael-phillips
Copy link
Contributor

@carlosga is this currently blocking you or do you have a workaround?

@boaz0
Copy link
Member

boaz0 commented Aug 12, 2019

A possible workaround is to pass pf-m-lg or pf-m-sm to the className prop of EmptyState

  <EmptyState className='pf-m-sm'>
    <EmptyStateIcon icon={CubesIcon} />
    <Title headingLevel="h5" size="lg">
      Empty State
    </Title>
    <EmptyStateBody>
      This represents an the empty state pattern in Patternfly 4.
    </EmptyStateBody>
    <Button variant="primary">Primary Action</Button>
    <EmptyStateSecondaryActions>
      <Button variant="link">Multiple</Button>
      <Button variant="link">Action Buttons</Button>
      <Button variant="link">Can</Button>
      <Button variant="link">Go here</Button>
      <Button variant="link">In the secondary</Button>
      <Button variant="link">Action area</Button>
    </EmptyStateSecondaryActions>
  </EmptyState>

//cc @carlosga @rachael-phillips

@carlosga
Copy link
Author

@carlosga is this currently blocking you or do you have a workaround?

No, 'it's not blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 React issues for the PF4 core effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants