Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table with column 'ID' breaks React keys #4835

Closed
mohd-akram opened this issue Sep 17, 2020 · 3 comments · Fixed by #5152
Closed

Table with column 'ID' breaks React keys #4835

mohd-akram opened this issue Sep 17, 2020 · 3 comments · Fixed by #5152
Labels

Comments

@mohd-akram
Copy link

Describe the issue. What is the expected and unexpected behavior?

Expected behavior: no errors
Actual behavior: Encountered two children with the same key, [object Object]-row.

https://codesandbox.io/s/youthful-noyce-s1bwg?file=/index.js

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?

Bug. Don't know what's the workaround apart from renaming the column which one shouldn't have to do.

@KKoukiou
Copy link
Collaborator

KKoukiou commented Sep 17, 2020

@mohd-akram I had the same issue some months ago #3090

There is a clean workaround there which I think it's easy to implement to avoid rewriting this component's code.

@renanrodrigo
Copy link

+1 to this - although a workaround exists, there could be a fix in the resolve-row-key to avoid this

@redallen
Copy link
Contributor

Duplicate of #3090 and #4283 which we never resolved. I think our workarounds are fine, but we should modify one of our examples to add an id column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants