fixes issues related to tables with an ID column #5152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcfaul
previously approved these changes
Nov 17, 2020
|
PF4 preview: https://patternfly-react-pr-5152.surge.sh |
redallen
approved these changes
Nov 17, 2020
redallen
suggested changes
Nov 17, 2020
redallen
approved these changes
Nov 17, 2020
kmcfaul
approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #5152 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 571 571
Lines 10631 10631
Branches 3958 3958
=======================================
Hits 5558 5558
Misses 4368 4368
Partials 705 705
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #4835, Closes #5076
There was a naming collision between the internal Table's rowKey which was named
id, and tables that have anIDcolumn