You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mcarrano it might be able to be held off for now since the React implementation works as intended. One reason to get it done in advance is since the v5 update in Core was merged in it would make sense to use the new CSS variable from the get-go. @kmcfaul wdyt?
It isn't a visible change from the user's perspective, so it may be able to wait. I don't think the CSS relies on the variable being set ( correct me if I'm wrong @mattnolting@mcoker ) and the table is setting right manually currently. If a user was overriding the table styling it would be more consistent to use the CSS variable still.
I will be in this area of code fixing a styling conflict from the v4 cherry pick that adds this feature back to v5 so I'll be updating the css variable while I'm there.
Followup to #8714 which made updates to the v4 branch, and patternfly/patternfly#5393 which provided the CSS variable for v5.
The text was updated successfully, but these errors were encountered: