Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table - update "right" property in td and th components #8776

Closed
thatblindgeye opened this issue Mar 3, 2023 · 5 comments · Fixed by #8928
Closed

Table - update "right" property in td and th components #8776

thatblindgeye opened this issue Mar 3, 2023 · 5 comments · Fixed by #8928
Assignees
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF5
Milestone

Comments

@thatblindgeye
Copy link
Contributor

Followup to #8714 which made updates to the v4 branch, and patternfly/patternfly#5393 which provided the CSS variable for v5.

@thatblindgeye thatblindgeye added Feature end user feature that requires design to define this, i.e. changes or augments the user experience. needs triage PF5 labels Mar 3, 2023
@mcarrano
Copy link
Member

@thatblindgeye does this need to be done in advance of the major release or can it wait?

@thatblindgeye
Copy link
Contributor Author

@mcarrano it might be able to be held off for now since the React implementation works as intended. One reason to get it done in advance is since the v5 update in Core was merged in it would make sense to use the new CSS variable from the get-go. @kmcfaul wdyt?

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 4, 2023

It isn't a visible change from the user's perspective, so it may be able to wait. I don't think the CSS relies on the variable being set ( correct me if I'm wrong @mattnolting @mcoker ) and the table is setting right manually currently. If a user was overriding the table styling it would be more consistent to use the CSS variable still.

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 5, 2023

I will be in this area of code fixing a styling conflict from the v4 cherry pick that adds this feature back to v5 so I'll be updating the css variable while I'm there.

@mcarrano
Copy link
Member

mcarrano commented Apr 5, 2023

cc @tlabaj @nicolethoen ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF5
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants